[Bug]: Broken on KDE 5.27 beta #473

rakbladsvalsen · 2023-01-29T22:14:23Z

Summary

Just as the title suggests, Bismuth is broken KDE 5.27 (beta).

Sometimes windows are not "detected" (or not tracked?) and bismuth is, in this case, useless. All keyboard shortcuts don't have any effect at all on windows, it's basically as if the extension was disabled.

When it does work everything is very buggy: some windows open in tiled mode, and some others open in floating mode. Windows opened in floating mode don't seem to be detected by bismuth at all, and "Toggle floating mode" doesn't re-tile them again.

This probably has something to do with the tilling changes introduced in KDE 5.27, but I'm not completely sure about this.

Steps to Reproduce

Just use bismuth on 5.27.
I'm only using Tile Layout.

Expected behavior

No buggy behavior.

Screenshots

No response

Bismuth version

3.1.4

KDE Plasma version

5.26.90 (5.27 beta)

The platform KWin is running on

Wayland

Additional context

pacman -Q | grep plasma:

kdeplasma-addons 5.26.90-1
plasma-browser-integration 5.26.90-1
plasma-desktop 5.26.90-2
plasma-framework 5.102.0-1
plasma-integration 5.26.90-1
plasma-nm 5.26.90-1
plasma-pa 5.26.90-1
plasma-thunderbolt 5.26.90-1
plasma-wayland-session 5.26.90-1
plasma-workspace 5.26.90-1
plasma5-applets-netspeed 1.9-1.1
plasma5-applets-window-title-git 0.7.1.r0.gb785c0a-1.1

The text was updated successfully, but these errors were encountered:

RobertBuhren · 2023-01-31T23:34:53Z

I´ 'm using bismuth on KDE 5.7 Beta with X11 and I don't see any bigger issues so far.

jkcdarunday · 2023-02-16T19:15:15Z

Can confirm that it's also broken on Plasma 5.27.0 (non-beta) using Wayland. All windows become resized to the full screen instead of being tiled.

jkcdarunday · 2023-02-16T20:01:40Z

So I played around with Firefox windows and observed the following logs and noted the actions/events that I did in square brackets:

[Opened Firefox]
Feb 17 03:29:38 [redacted] kwin_wayland[1600]: org.kde.bismuth: Client added: KWin::XdgToplevelWindow(0x555c17eff000)
Feb 17 03:29:38 [redacted] kwin_wayland[1600]: org.kde.bismuth: Oops! undefined: undefined.
[Created New Browser Window]
Feb 17 03:29:44 [redacted] kwin_wayland[1600]: org.kde.bismuth: Client added: KWin::XdgToplevelWindow(0x555c1811f760)
Feb 17 03:29:44 [redacted] kwin_wayland[1600]: org.kde.bismuth: onWindowAdded,[object Object]
Feb 17 03:29:44 [redacted] kwin_wayland[1600]: org.kde.bismuth: arrange
Feb 17 03:29:44 [redacted] kwin_wayland[1600]: org.kde.bismuth: arrangeScreen/finished,[object Object]
Feb 17 03:29:44 [redacted] kwin_wayland[1600]: org.kde.bismuth: Client is ok, can manage. Bind events now...
Feb 17 03:29:44 [redacted] kwin_wayland[1600]: org.kde.bismuth: onWindowChanged,[object Object]
Feb 17 03:29:44 [redacted] kwin_wayland[1600]: org.kde.bismuth: arrange
Feb 17 03:29:44 [redacted] kwin_wayland[1600]: org.kde.bismuth: arrangeScreen/finished,[object Object]
[Login Popup of a Firefox Extension Appears]
Feb 17 03:29:47 [redacted] kwin_wayland[1600]: org.kde.bismuth: Client added: KWin::XdgToplevelWindow(0x555c182ac080)
Feb 17 03:29:47 [redacted] kwin_wayland[1600]: org.kde.bismuth: Oops! undefined: undefined.
[Created New Window]
Feb 17 03:29:52 [redacted] kwin_wayland[1600]: org.kde.bismuth: Client added: KWin::XdgToplevelWindow(0x555c182b26c0)
Feb 17 03:29:52 [redacted] kwin_wayland[1600]: org.kde.bismuth: Oops! undefined: undefined.
[Created New Window]
Feb 17 03:29:58 [redacted] kwin_wayland[1600]: org.kde.bismuth: Client added: KWin::XdgToplevelWindow(0x555c17ec9d40)
Feb 17 03:29:58 [redacted] kwin_wayland[1600]: org.kde.bismuth: onWindowAdded,[object Object]
Feb 17 03:29:58 [redacted] kwin_wayland[1600]: org.kde.bismuth: arrange
Feb 17 03:29:58 [redacted] kwin_wayland[1600]: org.kde.bismuth: arrangeScreen/finished,[object Object]
Feb 17 03:29:58 [redacted] kwin_wayland[1600]: org.kde.bismuth: Client is ok, can manage. Bind events now...
Feb 17 03:29:58 [redacted] kwin_wayland[1600]: org.kde.bismuth: onWindowChanged,[object Object]
Feb 17 03:29:58 [redacted] kwin_wayland[1600]: org.kde.bismuth: arrange
Feb 17 03:29:58 [redacted] kwin_wayland[1600]: org.kde.bismuth: arrangeScreen/finished,[object Object]

I notice that if I create enough windows, new windows start to actually get tiled. The main culprit seems to be the Oops! undefined: undefined. error right after the "Client added" event.

Looking at the code, it seems that the ff. line might be the one throwing the error as the "onWindowAdded" message which should be the first line of the onWindowAdded function call below it is never logged.

bismuth/src/kwinscript/driver/index.ts

Line 167 in ef69afe

const window = this.windowMap.add(client);

This .add function seems to be calling the constructors of DriverWindowImpl and EngineWindowImpl that mostly reads window information from the KWin API.

Now not sure yet which of these reads actually throws the error and whether or not this is a bismuth or an upstream issue.

jkcdarunday · 2023-02-16T20:05:02Z

Also adding that it does work well with X11 on Plasma 5.27.0. The issue only happens on Wayland.

CarlosEkisde · 2023-02-18T21:05:14Z

I managed to get it working in Xorg, I don't know how, I'm almost sure that the last time I tested on Xorg it showed the same faulty behaviour. On the other hand I've seen this commit landing on the kwin side KDE/kwin@96fdc9d It seems very closely related to our problem. So maybe our pain is soon going to reach an end.

intentionally-left-nil · 2023-02-19T02:50:38Z

@CarlosEkisde: Built Plasma/kwin from source, but unfortunately it doesn't seem to fix the issue

Akergez · 2023-02-22T06:23:25Z

Can confirm it on 5.27, wayland, Fedora Kinoite. Works very unstable

Jeoshua · 2023-02-23T18:15:24Z

Honestly, I haven't noticed this plugin being any more or less stable under 5.27 (Kubuntu Beta PPA, X11 OR Wayland) than it has ever been. Yeah, there are some minor issues, but, again, nothing I didn't see in 5.26.

Vistaus · 2023-02-27T21:11:25Z

It works for me on 5.27.1 Wayland on Tumbleweed, however, it's a little buggy. Some windows don't get autotiled and already tiled windows don't resize back to bigger tiles.

dinotheextinct · 2023-02-28T19:35:44Z

It works for me on 5.27.1 Wayland on Tumbleweed, however, it's a little buggy. Some windows don't get autotiled and already tiled windows don't resize back to bigger tiles.

Its not just a little buggy, its completely random buggy. Opening 10 Terminals in a row gives different results. (some tiled some arent)

Unuseable for me in this state.

HelmicNewciv · 2023-03-17T08:04:32Z

Can report the same issue on Wayland. Normally it takes the form of a centered floating window, and I"ll have to close and re-open that app multiple times to get a version that'll tile, but I just managed to get a form where my browser window was using the 3 column layout - max vertical, taking up about 1/2 the screen centered. And I had just been using the 3 column layout moments prior. I kept closing and repoening until I could get a tiling verison again, and it kept being that same layout.

Sometimes windows that were working also seem to randomly stop responding ot Bismuth. Makes swwapping between windows very difficult. It also mucks up the UI's of many apps that don't expect to be that small, rendering them inoperable until I either fix their layout with my mouse (I don't have tilebars or borders on applications to save screen space when using many windows) or I close and re-open them.

Maybe KDE's new tiling features will make this not a problem soon.

Vistaus · 2023-03-17T09:34:49Z

@HelmicNewciv The only thing I miss from KDE's new tiling features is autotiling, which Bismuth does have. Someone has created a script for that now (https://store.kde.org/p/2003956), but it's supposedly very buggy and limited.

alxlg · 2023-03-18T16:49:45Z

Relevant fix for Krohnkite, can someone running Plasma 5.27 test the same change with Bismuth maybe?

esjeon/krohnkite#213 (comment)

Thaodan · 2023-03-28T07:01:40Z

Relevant fix for Krohnkite, can someone running Plasma 5.27 test the same change with Bismuth maybe?

esjeon/krohnkite#213 (comment)

Maybe try to apply the change here:

bismuth/src/tile.ts

Line 84 in 18cba1c

const size = this.client.clientSize;

alxlg · 2023-04-01T09:34:06Z

@Thaodan thanks, did you or anyone else have the chance to try it? I have not Plasma 5.27 to test it.

Thaodan · 2023-04-01T10:17:13Z

Alex L ***@***.***> writes:

@Thaodan thanks, did you or anyone else have the chance to try it? I have not Plasma 5.27 to test it.

My comment was wrong I think, Bismuth isn't using the property anymore.

jkcdarunday · 2023-07-13T10:02:37Z

I think I may have found the cause of the undefined issue in my earlier comment and managed to fix it. I created PR #490 which fixes a lot of issues on Wayland for me.

So far, bismuth is working great with the changes in the PR above but I have yet to use it for a day.

dobladez · 2023-07-13T14:54:07Z

I confirm @jkcdarunday 's PR #490 solves the issue for me. Thanks!

endeavour · 2023-08-03T19:53:16Z

Fixes it for me too, much appreciated!

endeavour · 2023-08-03T19:54:52Z

I noticed this also fixes an issue in KDE Dolphin where if you start typing into the location textbox the dropdown appears in wrong place on the screen. :)

Edit: Sometimes anyway... seems to be some weird edge cases

rakbladsvalsen added the bug Something isn't working label Jan 29, 2023

gikari mentioned this issue Jan 31, 2023

Future of the project after 5.27 #471

Open

zany130 mentioned this issue Jun 19, 2023

[Request] kwin-polonium (successor to bismuth) chaotic-aur/packages#2587

Closed

jkcdarunday linked a pull request Jul 13, 2023 that will close this issue

fix: Use optional chaining to fix error when windowId is undefined in Wayland #490

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug]: Broken on KDE 5.27 beta #473

[Bug]: Broken on KDE 5.27 beta #473

rakbladsvalsen commented Jan 29, 2023 •

edited

RobertBuhren commented Jan 31, 2023

jkcdarunday commented Feb 16, 2023

jkcdarunday commented Feb 16, 2023

jkcdarunday commented Feb 16, 2023

CarlosEkisde commented Feb 18, 2023 •

edited

intentionally-left-nil commented Feb 19, 2023

Akergez commented Feb 22, 2023

Jeoshua commented Feb 23, 2023

Vistaus commented Feb 27, 2023 •

edited

dinotheextinct commented Feb 28, 2023

HelmicNewciv commented Mar 17, 2023

Vistaus commented Mar 17, 2023 •

edited

alxlg commented Mar 18, 2023

Thaodan commented Mar 28, 2023

alxlg commented Apr 1, 2023

Thaodan commented Apr 1, 2023 via email

jkcdarunday commented Jul 13, 2023

dobladez commented Jul 13, 2023

endeavour commented Aug 3, 2023

endeavour commented Aug 3, 2023 •

edited

[Bug]: Broken on KDE 5.27 beta #473

[Bug]: Broken on KDE 5.27 beta #473

Comments

rakbladsvalsen commented Jan 29, 2023 • edited

Summary

Steps to Reproduce

Expected behavior

Screenshots

Bismuth version

KDE Plasma version

The platform KWin is running on

Additional context

RobertBuhren commented Jan 31, 2023

jkcdarunday commented Feb 16, 2023

jkcdarunday commented Feb 16, 2023

jkcdarunday commented Feb 16, 2023

CarlosEkisde commented Feb 18, 2023 • edited

intentionally-left-nil commented Feb 19, 2023

Akergez commented Feb 22, 2023

Jeoshua commented Feb 23, 2023

Vistaus commented Feb 27, 2023 • edited

dinotheextinct commented Feb 28, 2023

HelmicNewciv commented Mar 17, 2023

Vistaus commented Mar 17, 2023 • edited

alxlg commented Mar 18, 2023

Thaodan commented Mar 28, 2023

alxlg commented Apr 1, 2023

Thaodan commented Apr 1, 2023 via email

jkcdarunday commented Jul 13, 2023

dobladez commented Jul 13, 2023

endeavour commented Aug 3, 2023

endeavour commented Aug 3, 2023 • edited

rakbladsvalsen commented Jan 29, 2023 •

edited

CarlosEkisde commented Feb 18, 2023 •

edited

Vistaus commented Feb 27, 2023 •

edited

Vistaus commented Mar 17, 2023 •

edited

endeavour commented Aug 3, 2023 •

edited