Fixed Canny comparison page structured data breadcrumbs

Bimbalacom · Apr 17, 2024 · e5fb4ab · e5fb4ab
1 parent c184ef8
commit e5fb4ab
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/app/Http/Controllers/ComparisonController.php b/app/Http/Controllers/ComparisonController.php
@@ -39,17 +39,13 @@ public function canny(Request $request): Factory|View|Application
      * @param string|null $url
      * @return BreadcrumbList
      */
-    private function generateBreadCrumbSchema(string $name = null, string $url = null): BreadcrumbList
+    private function generateBreadCrumbSchema(string $name, string $url): BreadcrumbList
     {
         $listElements = [
-            Schema::listItem()->position(1)->url(route('comparison.index'))->name('Comparison')
-                ->setProperty('item', route('comparison.index'))
-        ];
-        if($name !== null){
-            $listElements[] = Schema::listItem()->position(2)
+            Schema::listItem()->position(1)
                 ->url($url)->name($name)
-                ->setProperty('item', $url);
-        }
+                ->setProperty('item', $url)
+        ];
 
         return Schema::breadcrumbList()
             ->name('Comparison Breadcrumbs')