Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the bug that PickView disappears #1025

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Ficat
Copy link

@Ficat Ficat commented Oct 13, 2022

Desc:
If we use custom layout , and in this PickView we click it's child views or areas which don't consume touch events,the following will occur.

  • If PickView shows as a dialog, PickView will disappear directly, even if setOutSideCancelable() is true or false
  • If not show as a dialog and setOutSideCancelable() is true, PickView still disappears

You can easily reproduce the situation in your sample app just by adding the follwing code to MainActivity#initCustomTimePicker(), run app and once you click the top middle area of the PickView (this area doesn't consume any touch events), you will find this PickView disappeared
.isDialog(true) .setOutSideCancelable(false) .build();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant