New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading indicator #1432
base: main
Are you sure you want to change the base?
Loading indicator #1432
Conversation
• the loading progress bar. • title attr now shows the status
• Code • Import
• stepsCount has added
• The "Updates" tab is now displayed
• Attribute "title" have been removed.
the function now takes an object parameter percent -> progress + hiddenProgress
-clear param -hiddenProgress param +subprogress param +substatus param +showProgress func +showSubProgress func +hideProgress func +hideSubProgress func
This is an interesting concept but would be way more confusing to end users that have no idea what any of those terms are. Additionally, the code is... interesting. It uses a constant number instead of a dynamic list of steps so each step has to calculate a new progress with magic numbers. I definitely don't like the change to the addon manager, that would never be accepted. Also using a Overall I think this change would not be helpful to end users. We already get debug information from the console when needed and this doesn't provide us with anything in that regard. @Strencher thoughts? |
Yeah same. I think it's enough to keep our current loading icon, optionally we could think about adding a toast at the end of BD loading that it's done. |
The main idea is the progress bar. If you have a lot of plugins or/and a weak PC you'll want to know when your Discord is ready. I don't think you should give it up. Text is a side feature. I assume we can remove statuses that users don't understand. |
It [■■■ ] makes the loading icon more informative.