Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#192 #193

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

#192 #193

wants to merge 2 commits into from

Conversation

zweissman
Copy link
Contributor

Added command line script convert_from_path.py
Updated ValueError message for Size not being a tuple or integer. It was missing the format part of the statement and added the actual type that is being passed.

Zeth Weissman added 2 commits March 24, 2021 15:54
Added command line script convert_from_path.py
Updated ValueError message for Size not being a tuple or integer. It was missing the format part of the statement and added the actual type that is being passed.
…age. That has to be called before the rest of the local imports.

Also, removing the code for uuid generator. the pdf2image code will handle the uuid generation if the user does not provide a output_file via the command line.
@Belval
Copy link
Owner

Belval commented Mar 31, 2021

Sorry I am a bit slower to respond these days. I have been working too much.

I like the idea of your PR and the code seems fine as well. I'll test it in the coming days and if it works it should be good to merge.

@Belval Belval self-requested a review March 31, 2021 02:08
@mara004
Copy link

mara004 commented Oct 26, 2021

  • --param_name -> --param-name (snake case in CLI arguments is uncommon - argparse will automatically convert the dest variable names to snake case for you)
  • help="int: ... -> type=int (rather than putting type names into help, it would make a lot more sense to use the type parameter to actually enforce correct types and ensure useful error messages)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants