Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle identifiers in subscript #1601

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

elsapet
Copy link
Contributor

@elsapet elsapet commented May 17, 2024

Description

If there is an identifier in the subscript, we want to track this back to its origin

With this change, we can now pick up both of these cases:

globals()[input()] # no identifier

x = input()
globals()[x] # identifier

Checklist

If this is your first time contributing please sign the CLA

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.

@elsapet elsapet force-pushed the fix/handle-identifiers-in-subscript branch from b1f0f3e to 429d87e Compare May 20, 2024 09:29
@elsapet elsapet merged commit 06a525d into main May 20, 2024
8 checks passed
@elsapet elsapet deleted the fix/handle-identifiers-in-subscript branch May 20, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants