Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jbeam / pc language icons easy fix #6

Merged
merged 1 commit into from May 14, 2024
Merged

Conversation

Sopze92
Copy link
Contributor

@Sopze92 Sopze92 commented May 12, 2024

Issue

  1. Providing an icon-theme for jbeam/pc along with replacement icons for json/dae/images may be quite annoying
  2. Package lacks the iconTheme contribution point for the icon-theme to work (or i'm too dumb, because I can't get your icons working at all)

Changes:

  • Added the jbeam/pc icons as language-icons, which is a better option than to use an icon-theme
  • Icons are now more BeamNG-ish, also included dark-mode icons

Pics

image image

@angelo234
Copy link
Collaborator

angelo234 commented May 14, 2024

Hmm I didn't realize that language icons could be set and the current ones before your commit don't seem to show for me also. So thanks for fixing it :)

@angelo234 angelo234 merged commit 6053b37 into BeamNG:master May 14, 2024
@angelo234
Copy link
Collaborator

I think I'll delete the whole "beamng-icon-theme.json" file too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants