Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves Issue with MacOS when loading ide #432

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

seacloud9
Copy link

Issue this update resolves here

After the result, it look like this:

loading-error-mac-os-resolved.mov
  • resolves macOS errors by enabling the tools wait and reverting a recent change to preload/editor that negatively impacts macOS

…nt change to preload/editor that negatively impacts macOS
@seacloud9 seacloud9 changed the title Resolves Issue with MacOS when loading ide May 10, 2023
@julien-moreau
Copy link
Contributor

Hey @seacloud9 !

This is annoying on my side because I don't reproduce on my macOS.
Are you using an arm64 build or a x64 one ?

The problem here is that editorExports.editor = (window as any).editor; is mandatory for JS scripts executable in assets and require('../renderer/module.js'); as well to run projects inside the editor :(

@seacloud9
Copy link
Author

Hello @julien-moreau,

I agree. I noticed that the code was much cleaner with those changes in, but I had to rewind the commits to find where MacOS stopped working. I will spend some time today to see if I can not investigate a better fix rather than a revert.

I am using M1/arm64. This is an excellent project! Thanks for sharing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MacOS bug when loading
2 participants