Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS bug when loading #431

Closed
seacloud9 opened this issue May 10, 2023 · 1 comment · May be fixed by #432
Closed

MacOS bug when loading #431

seacloud9 opened this issue May 10, 2023 · 1 comment · May be fixed by #432

Comments

@seacloud9
Copy link

It looks like this commit introduced this bug on macOS:

loading-error-macos.mov

https://github.com/BabylonJS/Editor/blob/533786c70251bba4db3bc4a1b89e15aa31a4e042/src/preloaders/editor.ts

window.addEventListener("DOMContentLoaded", async () => {
    await Tools.Wait(100); // this appears to be needed for macOS 

    const htmlFile = basename(window.location.href);

    if (htmlFile === "editor.html") {
        return runEditor();
    }

    if (htmlFile === "play.html") {
        return runIsolatedPlay();
    }
});
@julien-moreau
Copy link
Contributor

Closing this issue as we are discussing on the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants