Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

control: the name of the sample do not contain the underscore (_) #73

Open
pnatividad-incliva opened this issue Feb 16, 2022 · 2 comments · May be fixed by #267
Open

control: the name of the sample do not contain the underscore (_) #73

pnatividad-incliva opened this issue Feb 16, 2022 · 2 comments · May be fixed by #267
Assignees
@saramonzon
Labels
enhancement New feature or request
Milestone
Ready for deliver...

Comments

@pnatividad-incliva
Copy link

When loading the SampleSheet or registering samples in iSkyLIMS, it should check that the names of the samples do not contain the underscore (_), as they then give errors when analyzed in the pipelines used.
@luissian luissian self-assigned this Nov 1, 2022
@luissian luissian added this to the Release v2.3.0 milestone Nov 1, 2022
@luissian luissian added the enhancement New feature or request label Nov 1, 2022
@saramonzon saramonzon removed this from the Release v2.3.1 milestone Apr 10, 2023
@saramonzon saramonzon self-assigned this Apr 10, 2023
@saramonzon saramonzon added this to the v2.3.1 milestone Apr 10, 2023
@luissian luissian removed this from the v2.3.1 milestone May 8, 2023
@luissian
Copy link
Member

luissian commented May 8, 2023

Remove from this milestone.
Implementation of this issue will be done when recording sample was not fetched from sampleSheet or when collecting information from sequencer files.

@luissian luissian linked a pull request May 18, 2024 that will close this issue
Draft
@luissian
Copy link
Member

Added on version 3.1.0 which include a configuration parameter to allow or not the underscore character on sample

  • ALLOW_SAMPLE_NAMES_WITH_UNDERSCORE

By default is set to FALSE

@luissian luissian linked a pull request May 26, 2024 that will close this issue
implemented issue part 2 #267
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saramonzon saramonzon

Labels
enhancement New feature or request
Projects
None yet
Milestone
Ready for delivery to production
Development

Successfully merging a pull request may close this issue.

implemented issue part 2 luissian/iskylims
3 participants
@saramonzon @luissian @pnatividad-incliva