Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding the ability to maintain the placeholder color if desired #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mattaebersold
Copy link

@weotch I added this, which was to solve this issue on Clif https://app.asana.com/0/1199094171432804/1200386443419587/f

Problem:

  • when the image is loaded, the check for showImage does 2 things
    1. it fades in the image
    1. it fades out the placeholder element
  • Since both of those have a transition, you see the drop-shadow element for a second as the transition is happening on both
  • My idea for the fix is to pass a prop called maintainPlaceholder which doesn't wrap .vv-placeholder in the transition

If you have an opinion on a better way to go about this, or at least how to clean up me needing to render the .vv-placeholder element twice, then let me know

This works locally on clif for me, and passing maintainPlaceholder as a prop lets me control this on a component-by-component basis, because I don't want this to happen on say, transparent pngs

@mattaebersold mattaebersold requested a review from weotch June 7, 2021 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant