Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order the release of application parent chart #238

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

nitishm
Copy link
Contributor

@nitishm nitishm commented May 14, 2021

Closes #235

Signed-off-by: Nitish Malhotra nitish.malhotra@gmail.com

Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>
Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2021

Codecov Report

Merging #238 (287b3be) into main (683fc3f) will decrease coverage by 0.11%.
The diff coverage is 10.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
- Coverage   31.31%   31.20%   -0.12%     
==========================================
  Files           5        5              
  Lines        1025     1032       +7     
==========================================
+ Hits          321      322       +1     
- Misses        676      682       +6     
  Partials       28       28              
Impacted Files Coverage Δ
pkg/workflow/argo.go 1.76% <0.00%> (-0.03%) ⬇️
controllers/appgroup_reconciler.go 50.64% <100.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 683fc3f...287b3be. Read the comment docs.

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small asks

api/v1alpha1/appgroup_types.go Show resolved Hide resolved
api/v1alpha1/appgroup_types.go Outdated Show resolved Hide resolved
controllers/appgroup_reconciler.go Outdated Show resolved Hide resolved
Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>
Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>
@nitishm
Copy link
Contributor Author

nitishm commented May 19, 2021

@jonathan-innis are we good to merge this?

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>
Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide option to order the release of the application parent chart as compared to the subcharts
3 participants