bugfix for RequiredStatusChange (#251)

* bugfix for RequiredStatusChange * fix test Co-authored-by: jianye xi <jianyxi@microsoft.com>
Azure · Nov 2, 2022 · 3e91e3a · 3e91e3a
1 parent 1067c32
commit 3e91e3a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/openapi-diff/src/modeler/AutoRest.Swagger/Model/Schema.cs b/openapi-diff/src/modeler/AutoRest.Swagger/Model/Schema.cs
@@ -253,13 +253,13 @@ private void CompareProperties(ComparisonContext<ServiceDefinition> context, Sch
                         // required to optional
                         if (Required != null && Required.Contains(def.Key) && (priorSchema.Required == null || !priorSchema.Required.Contains(def.Key)))
                         {
-                            context.LogBreakingChange(ComparisonMessages.RequiredStatusChange, true, false);
+                            context.LogBreakingChange(ComparisonMessages.RequiredStatusChange, false, true);
                         }
 
                         // optional to required
                         if ((Required == null || !Required.Contains(def.Key)) && (priorSchema.Required != null && priorSchema.Required.Contains(def.Key)))
                         {
-                            context.LogBreakingChange(ComparisonMessages.RequiredStatusChange, false, true);
+                            context.LogBreakingChange(ComparisonMessages.RequiredStatusChange, true, false);
                         }
 
                         context.PushProperty(def.Key);

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@azure/oad",
-  "version": "0.10.1",
+  "version": "0.10.2",
   "author": {
     "name": "Microsoft Corporation",
     "email": "azsdkteam@microsoft.com",

diff --git a/src/test/test.ts b/src/test/test.ts
@@ -367,7 +367,7 @@ describe("index", () => {
         code: "RequiredStatusChange",
         docUrl: "https://github.com/Azure/openapi-diff/tree/master/docs/rules/1025.md",
         id: "1025",
-        message: "The 'required' status changed from the old version('True') to the new version('False').",
+        message: "The 'required' status changed from the old version('False') to the new version('True').",
         mode: "Update",
         new: {
           location: "file:///D:/a/1/s/src/test/expandsAllOf/new/property_format_change.json:35:7",