Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ppt live cc lines #4619

Merged
merged 3 commits into from
May 16, 2024
Merged

Conversation

JamesBurnside
Copy link
Member

What

Remove ppt live cc lines now feature has GA

Why

Cleanup

How Tested

n/a - rely on CI

Copy link
Contributor

Copy link
Contributor

github-actions bot commented May 15, 2024

Calling bundle size is decreased✅.

  • Current size: 4845588
  • Base size: 4845594
  • Diff size: -6

Copy link
Contributor

github-actions bot commented May 15, 2024

CallWithChat bundle size is decreased✅.

  • Current size: 6305289
  • Base size: 6305295
  • Diff size: -6

Copy link
Contributor

github-actions bot commented May 15, 2024

Chat bundle size is not changed.

  • Current size: 2185964
  • Base size: 2185964
  • Diff size: 0

Copy link
Contributor

github-actions bot commented May 15, 2024

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 25390 / 39578
64.15%
25390 / 39578
64.15%
694 / 1222
56.79%
1980 / 3154
62.77%
Current 25417 / 39545
64.27%
25417 / 39545
64.27%
694 / 1222
56.79%
2009 / 3175
63.27%
Diff 27 / -33
0.12%
27 / -33
0.12%
0 / 0
0%
29 / 21
0.5%

Copy link
Contributor

github-actions bot commented May 15, 2024

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 49829 / 79750
62.48%
49829 / 79750
62.48%
1013 / 2245
45.12%
2906 / 4746
61.23%
Current 49757 / 79719
62.41%
49757 / 79719
62.41%
1013 / 2245
45.12%
2885 / 4726
61.04%
Diff -72 / -31
-0.07%
-72 / -31
-0.07%
0 / 0
0%
-21 / -20
-0.19%

Copy link
Contributor

Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@JamesBurnside JamesBurnside enabled auto-merge (squash) May 16, 2024 17:35
Copy link
Contributor

@JamesBurnside JamesBurnside merged commit eb7d7c3 into main May 16, 2024
41 checks passed
@JamesBurnside JamesBurnside deleted the jaburnsi/remove-ppt-live-cc-lines branch May 16, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not need changelog Changes that does not affect the published package in any way do not need changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants