Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RTE] Rich text editor migration to roosterjs component model packages #4603

Merged
merged 22 commits into from
May 17, 2024
Merged

[RTE] Rich text editor migration to roosterjs component model packages #4603

merged 22 commits into from
May 17, 2024

Conversation

vhuseinova-msft
Copy link
Member

@vhuseinova-msft vhuseinova-msft commented May 14, 2024 •
edited

What

  • Migration from Rooster JS v8 to v9
  • Migration from RoosterJS React components to our own

Why

How Tested

storybook, tests, bug bash

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@vhuseinova-msft
Merge remote-tracking branch 'origin/main' into rich-text-editor/migr…
a73a0b4 
…ation-to-roosterjs-v9
@vhuseinova-msft
Merge remote-tracking branch 'origin/main' into rich-text-editor/migr…
b75f756 
…ation-to-roosterjs-v9
@vhuseinova-msft
[RTE] Rooster component and some plugins migration (#4572)
b5d99f3
@vhuseinova-msft
Merge remote-tracking branch 'origin/main' into rich-text-editor/migr…
eca5541 
…ation-to-roosterjs-v9
@vhuseinova-msft
[RTE] Copy paste plugin migration (#4577)
71d208e
@vhuseinova-msft
Merge remote-tracking branch 'origin/main' into rich-text-editor/migr…
04c1177 
…ation-to-roosterjs-v9
@vhuseinova-msft
Rich text toolbar migration (#4583)
fc6ad0f
@vhuseinova-msft
[RTE] Rich text editor table functionality migration (#4593)
10ebef8
@vhuseinova-msft
Updated context menu plugin (#4594)
37af50e
@vhuseinova-msft
Merge main in rooster migration branch (#4596)
1d18444
@vhuseinova-msft
Merge remote-tracking branch 'origin/main' into rich-text-editor/migr…
4f074d5 
…ation-to-roosterjs-v9
@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-uzmimeobzp.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 14, 2024 •
edited

Chat bundle size is decreased✅.

  • Current size: 2052124
  • Base size: 2186017
  • Diff size: -133893

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 14, 2024 •
edited

CallWithChat bundle size is decreased✅.

  • Current size: 6170241
  • Base size: 6305342
  • Diff size: -135101

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 14, 2024 •
edited

Calling bundle size is decreased✅.

  • Current size: 4845640
  • Base size: 4845641
  • Diff size: -1

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 14, 2024 •
edited

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 25342 / 39545
64.08%		 25342 / 39545
64.08%		 694 / 1222
56.79%		 2002 / 3171
63.13%
Current 25773 / 40003
64.42%		 25773 / 40003
64.42%		 710 / 1255
56.57%		 2072 / 3255
63.65%
Diff 431 / 458
0.34%		 431 / 458
0.34%		 16 / 33
-0.22%		 70 / 84
0.52%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 14, 2024 •
edited

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 49734 / 79719
62.38%		 49734 / 79719
62.38%		 1013 / 2245
45.12%		 2888 / 4732
61.03%
Current 50261 / 80226
62.64%		 50261 / 80226
62.64%		 1028 / 2278
45.12%		 2964 / 4836
61.29%
Diff 527 / 507
0.26%		 527 / 507
0.26%		 15 / 33
0%		 76 / 104
0.26%

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-xlbsybdbni.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-rnhofqolpy.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-uqpxtsjpyx.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-ltuhroicla.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-sqyajxgowm.chromatic.com/

@vhuseinova-msft vhuseinova-msft requested review from a team as code owners May 16, 2024 17:44
@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-mohvsgytot.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-njbpbnfvlr.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-hiurgeyomf.chromatic.com/

@vhuseinova-msft vhuseinova-msft merged commit 2fcad5a into main May 17, 2024
41 checks passed
@vhuseinova-msft vhuseinova-msft deleted the rich-text-editor/migration-to-roosterjs-v9 branch May 17, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palatter palatter palatter approved these changes

@Leah-Xia-Microsoft Leah-Xia-Microsoft Leah-Xia-Microsoft approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@palatter palatter

@Leah-Xia-Microsoft Leah-Xia-Microsoft

Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vhuseinova-msft @palatter @Leah-Xia-Microsoft