Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RTE] Unit tests for RichTextSendBox #4551

Merged
merged 7 commits into from Apr 30, 2024
Merged

[RTE] Unit tests for RichTextSendBox #4551

merged 7 commits into from Apr 30, 2024

Conversation

palatter
Copy link
Member

What

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-pzwuyqysvn.chromatic.com/

@palatter palatter changed the title [DRAFT][RTE] Unit tests for RichTextSendBox and RichTextInputBoxComponent [RTE] Unit tests for RichTextSendBox Apr 29, 2024
@palatter palatter marked this pull request as ready for review April 29, 2024 22:16
@palatter palatter requested review from a team as code owners April 29, 2024 22:16
@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-gntqawzmvd.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 29, 2024 •
edited

CallWithChat bundle size is increased❗.

  • Current size: 6274621
  • Base size: 6274620
  • Diff size: 1

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 29, 2024 •
edited

Chat bundle size is increased❗.

  • Current size: 2150424
  • Base size: 2150423
  • Diff size: 1

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 29, 2024 •
edited

Calling bundle size is increased❗.

  • Current size: 4880026
  • Base size: 4880025
  • Diff size: 1

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 29, 2024 •
edited

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 25301 / 39283
64.4%		 25301 / 39283
64.4%		 698 / 1230
56.74%		 1991 / 3177
62.66%
Current 25305 / 39283
64.41%		 25305 / 39283
64.41%		 698 / 1230
56.74%		 2010 / 3192
62.96%
Diff 4 / 0
0.01%		 4 / 0
0.01%		 0 / 0
0%		 19 / 15
0.3%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 29, 2024 •
edited

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 49896 / 79343
62.88%		 49896 / 79343
62.88%		 1037 / 2301
45.06%		 2923 / 4794
60.97%
Current 49869 / 79343
62.85%		 49869 / 79343
62.85%		 1037 / 2301
45.06%		 2951 / 4798
61.5%
Diff -27 / 0
-0.03%		 -27 / 0
-0.03%		 0 / 0
0%		 28 / 4
0.53%

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-zshjjivwhs.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-jfmkqazosu.chromatic.com/

@palatter palatter merged commit bc4cf73 into main Apr 30, 2024
41 checks passed
@palatter palatter deleted the palatter/rich-text-unit-tests branch April 30, 2024 18:07
mgamis-msft pushed a commit that referenced this pull request May 1, 2024
@palatter @mgamis-msft
[RTE] Unit tests for RichTextSendBox (#4551)
7195eb8 
* Tests

* Update tests

* Remove inputbox test for now.

* CC

* CC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vhuseinova-msft vhuseinova-msft vhuseinova-msft approved these changes

@Leah-Xia-Microsoft Leah-Xia-Microsoft Leah-Xia-Microsoft approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@palatter @vhuseinova-msft @Leah-Xia-Microsoft