fix case when passcode was lost #4535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzdor
requested review from
JamesBurnside,
alkwa-msft,
dmceachernmsft,
carocao-msft,
edwardlee-msft,
PorterNan,
mgamis-msft,
prabhjot-msft,
AmyL219,
jimchou-dev,
vhuseinova-msft,
Leah-Xia-Microsoft,
jpeng-ms,
waynemo,
emlynmac,
JoshuaLai and
palatter
JamesBurnside
approved these changes
Apr 25, 2024
| @@ -245,10 +247,11 @@ export const HomeScreen = (props: HomeScreenProps): JSX.Element => { | |||
| label={'Passcode'} | |||
| placeholder={'Enter a meeting passcode'} | |||
| onChange={(_, newValue) => { | |||
| const meetingId = callLocator && 'meetingId' in callLocator ? callLocator.meetingId : ''; | |||
| const localMeetingId = meetingId ? meetingId : ''; | |||
There was a problem hiding this comment.
Is this line needed? meetingId can just be used
There was a problem hiding this comment.
this is just undefined check
There was a problem hiding this comment.
Right - but why have it? You have the check again below when localMeetingId ? is called
JamesBurnside
added
the
do not need changelog
@azure/communication-react jest test coverage for stable.
|
@azure/communication-react jest test coverage for beta.
|
…://github.com/Azure/communication-ui-library into ruslanz/meetingid-passcode-lost-url-parameter
Calling bundle size is decreased✅.
|
Chat bundle size is decreased✅.
|
CallWithChat bundle size is decreased✅.
|
prabhjot-msft
approved these changes
Apr 29, 2024
mgamis-msft
pushed a commit
that referenced
this pull request
May 1, 2024
* fix case when passcode was lost in url based on input order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
If I enter the passcode first, then enter the meetingId, the passcode isn't passed to the URL:
Why
How Tested
Process & policy checklist
Is this a breaking change?