Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share localization string between sendbox and editbox #4457

Merged
merged 7 commits into from May 10, 2024
Merged

Share localization string between sendbox and editbox #4457

merged 7 commits into from May 10, 2024

Conversation

Leah-Xia-Microsoft
Copy link
Member

What

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-mjtmbumlih.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024

Storybook URL https://60c7ae6891f0e90039d7cd54-eewlkiijeo.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-jpegmsuplb.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 10, 2024 •
edited

CallWithChat bundle size is increased❗.

  • Current size: 6318280
  • Base size: 6317173
  • Diff size: 1107

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 10, 2024 •
edited

Chat bundle size is increased❗.

  • Current size: 2183435
  • Base size: 2182328
  • Diff size: 1107

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 10, 2024 •
edited

Calling bundle size is increased❗.

  • Current size: 4892013
  • Base size: 4891050
  • Diff size: 963

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-jnhxqsrrmf.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-igmcmvwhqr.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 10, 2024 •
edited

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 25368 / 39378
64.42%		 25368 / 39378
64.42%		 699 / 1233
56.69%		 2019 / 3206
62.97%
Current 25399 / 39385
64.48%		 25399 / 39385
64.48%		 699 / 1233
56.69%		 2010 / 3196
62.89%
Diff 31 / 7
0.06%		 31 / 7
0.06%		 0 / 0
0%		 -9 / -10
-0.08%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 10, 2024 •
edited

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 49977 / 79631
62.76%		 49977 / 79631
62.76%		 1039 / 2305
45.07%		 2906 / 4781
60.78%
Current 49992 / 79644
62.76%		 49992 / 79644
62.76%		 1039 / 2305
45.07%		 2903 / 4779
60.74%
Diff 15 / 13
0%		 15 / 13
0%		 0 / 0
0%		 -3 / -2
-0.04%

@Leah-Xia-Microsoft Leah-Xia-Microsoft marked this pull request as ready for review May 10, 2024 20:37
@Leah-Xia-Microsoft Leah-Xia-Microsoft requested review from a team as code owners May 10, 2024 20:37
@Leah-Xia-Microsoft Leah-Xia-Microsoft enabled auto-merge (squash) May 10, 2024 22:01
@github-actions GitHub Actions
Copy link
Contributor

Storybook URL https://60c7ae6891f0e90039d7cd54-frbtiajnfi.chromatic.com/

@Leah-Xia-Microsoft Leah-Xia-Microsoft merged commit 777db03 into main May 10, 2024
41 checks passed
@Leah-Xia-Microsoft Leah-Xia-Microsoft deleted the leahxia/share-localization-string branch May 10, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlynmac emlynmac emlynmac approved these changes

@vhuseinova-msft vhuseinova-msft vhuseinova-msft approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@JamesBurnside JamesBurnside

@emlynmac emlynmac

@palatter palatter

@vhuseinova-msft vhuseinova-msft

Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Leah-Xia-Microsoft @JamesBurnside @emlynmac @vhuseinova-msft @palatter