New E2E plan file validation #2651
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adreed-msft
requested review from
gapra-msft,
nakulkar-msft,
siminsavani-msft,
vibhansa-msft,
seanmcc-msft and
pranavmalik-msft
as code owners
adreed-msft
force-pushed
the
adreed/new-e2e-plan-file-validation
branch
from
bcd83a9
to
d38956b
Compare
adreed-msft
force-pushed
the
adreed/new-e2e-plan-file-validation
branch
2 times, most recently
from
3c931d5
to
13f2475
Compare
gapra-msft
reviewed
May 9, 2024
| @@ -273,13 +273,24 @@ func (u *blobFSSenderBase) SetFolderProperties() error { | |||
|
|
|||
| func (u *blobFSSenderBase) DirUrlToString() string { | |||
| directoryURL := u.getDirectoryClient().DFSURL() | |||
| rawURL, err := url.Parse(directoryURL) | |||
| //rawURL, err := url.Parse(directoryURL) | |||
siminsavani-msft
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base: #2630
Merge that one first, then this.
This PR implements some basic testing of AzCopy plan files and solves a variety of other issues with the E2E framework, such as early exits and false positives.