Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AzCopy panics when uploading 16.5 TB disk snapshot to a container in blob storage #2635

Merged
merged 14 commits into from May 10, 2024
Merged

AzCopy panics when uploading 16.5 TB disk snapshot to a container in blob storage #2635

merged 14 commits into from May 10, 2024

Conversation

siminsavani-msft
Copy link
Member

@siminsavani-msft siminsavani-msft commented Apr 3, 2024 •
edited

  • Retrieve LMT through a helper method that handles if LMT is nil or not
  • Retrieve ContentLength through a helper method that handles if ContentLength is nil or not
  • E2E tests written to test locally and avoid lengthy testing time in CI due to large size of managed disk snapshot (7.9 TB). Must be set up locally.
  • Unit tests that mocks service GetProperties response
  • Resolves azcopy copy memory error on 10.23.0 MacOS via brew using SAS #2606

gapra-msft
gapra-msft reviewed Apr 3, 2024
View reviewed changes
cmd/zc_traverser_blob.go Outdated Show resolved Hide resolved
@siminsavani-msft siminsavani-msft marked this pull request as ready for review April 17, 2024 17:25
@siminsavani-msft siminsavani-msft added this to the 10.25.0 milestone Apr 17, 2024
gapra-msft
gapra-msft reviewed Apr 17, 2024
View reviewed changes
Copy link
Member

@gapra-msft gapra-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comments

@seanmcc-msft
Copy link
Member

seanmcc-msft commented Apr 18, 2024 •
edited

  1. Create end-to-end test to test locally
  2. Run this test locally
  3. Mark test as skip, follow up with Gauri on how to do this.
  4. Create long running test flag, apply to this E2E test
  5. Create unit test with mocks

adreed-msft
adreed-msft approved these changes Apr 22, 2024
View reviewed changes
cmd/zt_traverser_managed_disk_test.go Outdated Show resolved Hide resolved
@gapra-msft gapra-msft mentioned this pull request May 9, 2024
Closed
@siminsavani-msft siminsavani-msft merged commit d1dd6d3 into main May 10, 2024
17 checks passed
@siminsavani-msft siminsavani-msft deleted the siminsavani/azcopy-panic-managed-disk branch May 10, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adreed-msft adreed-msft adreed-msft approved these changes

@gapra-msft gapra-msft gapra-msft approved these changes

@nakulkar-msft nakulkar-msft Awaiting requested review from nakulkar-msft nakulkar-msft is a code owner

@vibhansa-msft vibhansa-msft Awaiting requested review from vibhansa-msft vibhansa-msft is a code owner

@seanmcc-msft seanmcc-msft Awaiting requested review from seanmcc-msft seanmcc-msft is a code owner

@pranavmalik-msft pranavmalik-msft Awaiting requested review from pranavmalik-msft pranavmalik-msft is a code owner

Assignees

@adreed-msft adreed-msft

@gapra-msft gapra-msft

Labels
None yet
Projects
None yet
Milestone
10.25.0
Development

Successfully merging this pull request may close these issues.

azcopy copy memory error on 10.23.0 MacOS via brew using SAS
4 participants
@siminsavani-msft @seanmcc-msft @adreed-msft @gapra-msft