Fix path joining in and test --delete-destination #2620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adreed-msft
requested review from
gapra-msft,
nakulkar-msft,
siminsavani-msft,
vibhansa-msft,
seanmcc-msft and
pranavmalik-msft
as code owners
adreed-msft
force-pushed
the
adreed/create-hash-data-folder
branch
2 times, most recently
from
e06e447
to
6241cc6
Compare
siminsavani-msft
approved these changes
May 2, 2024
adreed-msft
added a commit
that referenced
this pull request
May 9, 2024
#2611) * Automatically create the hash data directory when using an alternative * Remove sync.Once from struct * Remove unnecessary struct element * Fix test * Disable XAttr testing in CI * Fix path joining in and test --delete-destination (#2620) * Automatically create the hash data directory when using an alternative * Fix path joining in and test --delete-destination * Create share test fix * Backport fixes from NewE2E early exit changes * Remove sync.Once struct from hidden file adapter * Prevent crash in blob * Use my braincells
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is presently based on create-hash-data-folder, because much of the work is re-used.
Currently,
--delete-directoryis completely broken, because the usage ofpath.JoininsyncProcessor.gowas incorrect. This PR adds testing in for the feature in the E2E testing framework, and re-uses the work from it's base PR for objects creating their parents in the E2E framework.