New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for workload identity #2619
Open
gapra-msft
wants to merge
16
commits into
main
Choose a base branch
from
gapra/workloadIdentity
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+254
−165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
gapra-msft
commented
Mar 21, 2024
•
edited
edited
- Marks the servicePrincipal and identity flags as soon to be deprecated. This is replaced by login-type.
- Currently we have custom workload identity flags/env variables, but to me it seems reasonable to just rely on the default of the environment variables the Identity SDK uses, this would reduce our test burden.
gapra-msft
requested review from
adreed-msft,
nakulkar-msft,
siminsavani-msft,
vibhansa-msft,
seanmcc-msft and
pranavmalik-msft
as code owners
March 21, 2024 22:07
adreed-msft
reviewed
Mar 21, 2024
sugibuchi
reviewed
Mar 22, 2024
gapra-msft
commented
Mar 22, 2024
gapra-msft
commented
Mar 22, 2024
gapra-msft
commented
Mar 22, 2024
adreed-msft
reviewed
May 9, 2024
adreed-msft
reviewed
May 9, 2024
adreed-msft
reviewed
May 9, 2024
adreed-msft
reviewed
May 9, 2024
adreed-msft
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.