[BugFix] Minimise mumber of calls to folder create in case of Blob to File Copy #2591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavmalik-msft
requested review from
gapra-msft,
adreed-msft,
nakulkar-msft,
siminsavani-msft,
vibhansa-msft,
tasherif-msft and
seanmcc-msft
as code owners
gapra-msft
reviewed
Feb 23, 2024
| @@ -674,6 +674,12 @@ func NewFolderPropertyOption(fromTo common.FromTo, recursive, stripTopDir bool, | |||
| } | |||
| } | |||
|
|
|||
| // In case of a Blob to File Copy, we will go for all folder copy | |||
| if fromTo == common.EFromTo.BlobFile() { | |||
There was a problem hiding this comment.
I thought we decided to use the mitigation (customer sets include directory flag) and get to this issue in a later release after we have a solid plan?
@seanmcc-msft @vibhansa-msft thoughts?
There was a problem hiding this comment.
We can consider this fix for the next release (not for 10.23). Once we have more clarity on the flow, may be we can improvise the fix.
There was a problem hiding this comment.
We also need to consider the part where putting such check may take away the capabilities to skip empty folders while copying.
adreed-msft
requested changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request addresses a regression stemming from the existing logic for Blob to File Copy. Previously, the default case returned a nullFolderTracker, lacking the mechanism to track already created folders. Considering this a corner case, the proposed solution introduces the AllFolderCopy approach. With this enhancement, the foldertracker logic now effectively monitors previously created folders, thereby reducing redundant folder creation during Blob to File operations.
Changes: