fix: failed files should not be accounted as failed when the job is resumed #2462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, we should retry them
lukasz-krzykowski
requested review from
gapra-msft,
adreed-msft,
nakulkar-msft,
siminsavani-msft,
vibhansa-msft and
tasherif-msft
as code owners
lukasz-krzykowski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once the job is resumed I believe we should not treat any previous failures in statistics as the default behavior is to retry those failed elements. We do not want to end up in situation when if the retry succeeds - we would report the retried item both as failure and as a success.
This directly addresses an issue: #2461