Support asterisk on list #2316
Open
Support asterisk on list #2316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto asteriskOnList
Changing the default recursive option "on" in the ls command to allow the trailing wildcard in the directory name when the user wants.
nakulkar-msft
requested review from
gapra-msft,
adreed-msft,
siminsavani-msft,
vibhansa-msft and
tasherif-msft
as code owners
gapra-msft
reviewed
Aug 24, 2023
| func (raw rawListCmdArgs) cook() (cookedListCmdArgs, error) { | ||
| // returns result of stripping and if striptopdir is enabled | ||
| // if nothing happens, the original source is returned | ||
| func (raw *rawListCmdArgs) stripTrailingWildcardOnRemoteSource(location common.Location) (result string, stripTopDir bool, err error) { |
There was a problem hiding this comment.
@nakulkar-msft can we wait until adele's new e2e test framework is merged and add e2e tests for this and then support this feature?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.