Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script Generate Azcopy Throughput Report #2152

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

Conversation

tilimpo
Copy link

@tilimpo tilimpo commented Apr 11, 2023

  • Analyzes the azcopy log, and collects transfer metrics to generate a repot Example: .\AzcopyThroughput.ps1 -F "C:\Users\tml.azcopy\f2435d64-57ea-6949-7e62-006aa4ecf930.log"

- Analyzes the azcopy log, and collects transfer metrics to generate a repot Example:
             .\AzcopyThroughput.ps1 -F "C:\Users\tml\.azcopy\f2435d64-57ea-6949-7e62-006aa4ecf930.log"
@vibhansa-msft
Copy link
Member

Kindly push these files to a seperate 'tools' or 'utils' directory instead of root.

@vibhansa-msft vibhansa-msft added this to the 10.19.0 milestone Apr 12, 2023
Copy link
Member

@gapra-msft gapra-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, there seems to be quite a few typos in this file, particularly with the spelling of AzCopy, auxiliary, and report. If you could please resolve those, that would be super helpful!

Otherwise looks good. Will approve once those changes are made

typos already corrected
@tilimpo
Copy link
Author

tilimpo commented May 18, 2023

Hi, there seems to be quite a few typos in this file, particularly with the spelling of AzCopy, auxiliary, and report. If you could please resolve those, that would be super helpful!

Otherwise looks good. Will approve once those changes are made

Hi @gapra-msft, typos already corrected.

Thank you

gapra-msft
gapra-msft previously approved these changes May 23, 2023
$azcopyvalues += $item
}

$azcopyvalues | Export-Csv -NoClobber -NoTypeInformation -Encoding Unicode -Path C:\temp\ReporAzCopy_$logname.csv -Delimiter ";"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the path at the end be ReportAzCopy instead of ReporAzCopy?

Copy link
Member

@adreed-msft adreed-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would greatly prefer that the plotly.js script were not integrated into the template HTML file itself, but instead used the script reference provided on the plotly.js github page.

https://github.com/plotly/plotly.js/#the-script-html-element

This comes with a couple of distinct advantages:

  1. It is trivial to update in the future
  2. It is from a reliable trustworthy source (Not that I don't trust you, but a certain level of skepticism has to be taken to a good few thousand lines of minified js)
  3. It doesn't prevent the file from being reviewed on GitHub by making it too massive

In addition to this, we need to add a notice to our licenses for the new use of a third-party component (LICENSES.txt in the root).

adreed-msft
adreed-msft previously approved these changes May 24, 2023
@gapra-msft gapra-msft modified the milestones: 10.19.0, 10.20 May 24, 2023
1) Correction of CSV path
2) Adding any column for possible warning messages like "(Disk may be limiting speed)"
removing the quotes signal from CSV
improvement: can analyze the log even if the log is not completed, created a validation if the variable $tf is empty or not to avoid dividing a int per zero.

Also create a validation if the auxiliar file exists, to avoid send a instruction to delete something that not exists.
@tilimpo
Copy link
Author

tilimpo commented Oct 4, 2023

ng Contributor License Agreement(CLA). If you agree with the CLA, please reply with the follow

@microsoft-github-policy-service agree company="Microsoft"

@tilimpo
Copy link
Author

tilimpo commented Oct 9, 2023

ReportHTML.zip
I made some changes to the HTML file, which I would like to replace the existing one, the changes are as follows:

  • replacement of the js code with the public plotly link
  • addition of warnings to the graph
  • addition of a table with findings, which shows all the warnings that we had during the copy and what the meaning of these same warnings is.

@tilimpo tilimpo dismissed stale reviews from adreed-msft and gapra-msft via 4f2d670 January 12, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants