New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script Generate Azcopy Throughput Report #2152
base: dev
Are you sure you want to change the base?
Conversation
tilimpo
commented
Apr 11, 2023
- Analyzes the azcopy log, and collects transfer metrics to generate a repot Example: .\AzcopyThroughput.ps1 -F "C:\Users\tml.azcopy\f2435d64-57ea-6949-7e62-006aa4ecf930.log"
- Analyzes the azcopy log, and collects transfer metrics to generate a repot Example: .\AzcopyThroughput.ps1 -F "C:\Users\tml\.azcopy\f2435d64-57ea-6949-7e62-006aa4ecf930.log"
Kindly push these files to a seperate 'tools' or 'utils' directory instead of root. |
mover Report.html under utils directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, there seems to be quite a few typos in this file, particularly with the spelling of AzCopy, auxiliary, and report. If you could please resolve those, that would be super helpful!
Otherwise looks good. Will approve once those changes are made
typos already corrected
Hi @gapra-msft, typos already corrected. Thank you |
utils/AzcopyThroughput.ps1
Outdated
$azcopyvalues += $item | ||
} | ||
|
||
$azcopyvalues | Export-Csv -NoClobber -NoTypeInformation -Encoding Unicode -Path C:\temp\ReporAzCopy_$logname.csv -Delimiter ";" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should the path at the end be ReportAzCopy instead of ReporAzCopy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would greatly prefer that the plotly.js script were not integrated into the template HTML file itself, but instead used the script reference provided on the plotly.js github page.
https://github.com/plotly/plotly.js/#the-script-html-element
This comes with a couple of distinct advantages:
- It is trivial to update in the future
- It is from a reliable trustworthy source (Not that I don't trust you, but a certain level of skepticism has to be taken to a good few thousand lines of minified js)
- It doesn't prevent the file from being reviewed on GitHub by making it too massive
In addition to this, we need to add a notice to our licenses for the new use of a third-party component (LICENSES.txt in the root).
1) Correction of CSV path 2) Adding any column for possible warning messages like "(Disk may be limiting speed)"
removing the quotes signal from CSV
improvement: can analyze the log even if the log is not completed, created a validation if the variable $tf is empty or not to avoid dividing a int per zero. Also create a validation if the auxiliar file exists, to avoid send a instruction to delete something that not exists.
@microsoft-github-policy-service agree company="Microsoft" |
ReportHTML.zip
|