Skip to content

Commit

Permalink
Remove references to hack/generated and hack/generator (#3223)
Browse files Browse the repository at this point in the history
* Rename gitmodule
* Update docs
* Remove unused golden files
  • Loading branch information
theunrepentantgeek committed Sep 4, 2023
1 parent d1c7f88 commit 4773998
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 466 deletions.
2 changes: 1 addition & 1 deletion .gitmodules
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[submodule "hack/generator/specs/azure-rest-api-specs"]
[submodule "azure-rest-api-specs"]
path = v2/specs/azure-rest-api-specs
url = https://github.com/Azure/azure-rest-api-specs
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@ Once you have a working development environment, run the `task` command to run t
### \<Resource\> looks like a resource reference but was not labelled as one

Example:
> Replace cross-resource references with genruntime.ResourceReference:
> ["github.com/Azure/azure-service-operator/hack/generated/_apis/containerservice/v1alpha1api20210501/PrivateLinkResource.Id" looks like a resource reference but was not labelled as one.
> Replace cross-resource references with genruntime.ResourceReference:
> ["github.com/Azure/azure-service-operator/v2/apis/containerservice/v1api20210501/PrivateLinkResource.Id" looks like a resource reference but was not labelled as one.
To fix this error, determine whether the property in question is an ARM ID or not, and then update the `objectModelConfiguration` section in the configuration file.

Expand Down
6 changes: 4 additions & 2 deletions docs/hugo/content/contributing/developer-setup.md
Original file line number Diff line number Diff line change
Expand Up @@ -144,11 +144,13 @@ From the root of your ASO repo clone, run

``` bash
$ git submodule init
Submodule 'hack/generator/specs/azure-rest-api-specs' (https://github.com/Azure/azure-rest-api-specs) registered for path 'specs/azure-rest-api-specs'
Submodule 'azure-rest-api-specs' (https://github.com/Azure/azure-rest-api-specs) registered for path 'v2/specs/azure-rest-api-specs'

$ git submodule update
Cloning into '/workspaces/azure-service-operator/v2/specs/azure-rest-api-specs'...
Submodule path 'specs/azure-rest-api-specs': checked out '3ac733b1b1c63969fbed0c7ffe60ff5cccc708c7'
remote: Enumerating objects: 15, done.
... elided ...
Submodule path 'v2/specs/azure-rest-api-specs': checked out '35f8372749cbe9b1f69bde0eee3b0bc63c49c2c2'
```

The exact git hash that's checked out will likely be different.
Expand Down

This file was deleted.

This file was deleted.

0 comments on commit 4773998

Please sign in to comment.