Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Common Sanitizers #43660

Merged
merged 57 commits into from
May 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
8bf1aa9
target version of proxy with common sanitizers. update startup for th…
scbedd Apr 25, 2024
786328d
target version of proxy with updated common sanitizers
scbedd Apr 26, 2024
bc3d754
Remove id sanitizer
JoshLove-msft Apr 29, 2024
080a94d
remove start arg
JoshLove-msft Apr 29, 2024
c45f52c
Update the proxy version to one that is incapable of outputting to
scbedd Apr 29, 2024
18cd7c2
testing removal of sanitizers
JoshLove-msft Apr 30, 2024
6c887e3
target newest version of the proxy
scbedd Apr 30, 2024
d33bceb
newer test proxy with proper defaulting of default sanitizers for pri…
scbedd Apr 30, 2024
0df09e1
pin the correct version of the proxy
scbedd May 1, 2024
ba664a2
storage
JoshLove-msft May 1, 2024
32061a8
use base64 key
JoshLove-msft May 1, 2024
9ae499d
fix communication
JoshLove-msft May 1, 2024
10a2eb8
to/from
JoshLove-msft May 1, 2024
b6fe9a4
friendlyname
JoshLove-msft May 1, 2024
3ce54ec
metrics advisor
JoshLove-msft May 1, 2024
a765fe9
remove redacted
JoshLove-msft May 1, 2024
3ad7a74
copy source
JoshLove-msft May 2, 2024
e0d4fa4
newest proxy version. updating UserDelegationKey.SignedTid/SignedOid …
scbedd May 2, 2024
148c1c7
storage sanitizers
JoshLove-msft May 2, 2024
a29e9ae
cache guid string
JoshLove-msft May 2, 2024
f6c54a5
cache empty guid string
JoshLove-msft May 2, 2024
360f0af
mark attestation as liveonly
JoshLove-msft May 2, 2024
cfa5e18
bump to newest version of the proxy. stderr is ENABLED on this proxy …
scbedd May 2, 2024
8a7f34a
default the proxy to boot without output to stderr
scbedd May 2, 2024
3e84b66
ARM tests
JoshLove-msft May 3, 2024
4134c9b
Merge branch 'target-common-sanitizers-proxy' of https://github.com/A…
JoshLove-msft May 3, 2024
00a281d
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-net int…
JoshLove-msft May 3, 2024
2652c05
eh
JoshLove-msft May 3, 2024
338a49c
sasUri and x-ms-request-id
JoshLove-msft May 3, 2024
3756226
df
JoshLove-msft May 3, 2024
9a594b9
more arm
JoshLove-msft May 3, 2024
b56bfb3
Increase timeout due to more sanitizers being used
JoshLove-msft May 3, 2024
b32e12f
fix pattern
JoshLove-msft May 3, 2024
53d98ee
fix patterns
JoshLove-msft May 3, 2024
12b58ac
clean up
JoshLove-msft May 4, 2024
4f74964
clean up and mark lab test liveonly
JoshLove-msft May 4, 2024
d000111
newest version of the proxy
scbedd May 6, 2024
f09f20e
use newest proxy with adjustments to token replacement
scbedd May 6, 2024
f2723a1
Update eng/Packages.Data.props
JoshLove-msft May 6, 2024
cf1ffa0
ensure that all uses of regex globbing are +, add missing + to token …
scbedd May 6, 2024
1c18cf0
Merge branch 'target-common-sanitizers-proxy' of https://github.com/a…
scbedd May 6, 2024
9545fc4
token
JoshLove-msft May 6, 2024
d2f2a57
operation location
JoshLove-msft May 6, 2024
3d5dd25
clean
JoshLove-msft May 7, 2024
45d2c1c
df
JoshLove-msft May 7, 2024
651bffe
remove LiveOnly from KV
JoshLove-msft May 7, 2024
965ea33
remove additional unnecessary liveonly usages
JoshLove-msft May 7, 2024
8fefbeb
workloads
JoshLove-msft May 7, 2024
dca8c4e
mark recordedtest
JoshLove-msft May 7, 2024
5fb2df8
liveonly
JoshLove-msft May 7, 2024
84fffb1
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-net int…
JoshLove-msft May 7, 2024
7048d7f
try a version of the proxy that has slightly adjusted local caching
scbedd May 8, 2024
ae0c68f
Exclude search sanitizer
JoshLove-msft May 8, 2024
9bac1e7
:qw
JoshLove-msft May 8, 2024
3f8fdfc
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-net int…
JoshLove-msft May 8, 2024
1fc372d
fix pattern
JoshLove-msft May 8, 2024
f36508d
ignore token sanitizer for search
JoshLove-msft May 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Packages.Data.props
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@
</ItemGroup>

<PropertyGroup>
<TestProxyVersion>1.0.0-dev.20240410.2</TestProxyVersion>
<TestProxyVersion>1.0.0-dev.20240507.1</TestProxyVersion>
</PropertyGroup>

</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

namespace Azure.Security.Attestation.Tests
{
[LiveOnly(Reason = "JWT cannot be stored in recordings.")]
public class AttestationTests : RecordedTestBase<AttestationClientTestEnvironment>
{
// A Base64Url encoded pre-canned OpenEnclave Report, used to test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

namespace Azure.Security.Attestation.Tests
{
[LiveOnly(Reason = "JWT cannot be stored in recordings.")]
public class PolicyGetSetTests : RecordedTestBase<AttestationClientTestEnvironment>
{
public PolicyGetSetTests(bool isAsync) : base(isAsync)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public ProgrammableConnectivityClientTest(bool isAsync) : base(isAsync, Recorded
{
HeaderRegexSanitizers.Add(
new HeaderRegexSanitizer("apc-gateway-id", "**********/resourceGroups")
{ Regex = @"[A-Za-z0-9-\-]*/resourceGroups" });
{ Regex = @"[A-Za-z0-9-\-]+/resourceGroups" });
credential = TestEnvironment.Credential;
}

Expand Down
2 changes: 1 addition & 1 deletion sdk/communication/Azure.Communication.Rooms/assets.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "net",
"TagPrefix": "net/communication/Azure.Communication.Rooms",
"Tag": "net/communication/Azure.Communication.Rooms_b68cae7b87"
"Tag": "net/communication/Azure.Communication.Rooms_2bf926f910"
}
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public class RoomsClientLiveTestBase : RecordedTestBase<RoomsClientTestEnvironme
private const string DateTimeStampRegEx = @"[0-9]*-[0-9]*-[0-9]*T[0-9]*:[0-9]*:[0-9]*.[0-9]*Z";
private const string URIDomainNameReplacerRegEx = @"https://([^/?]+)";
private const string URIIdentityReplacerRegEx = @"/identities/([^/?]+)";
private const string URIRoomsIdReplacerRegEx = @"/rooms/\d*";
private const string URIRoomsIdReplacerRegEx = @"/rooms/\d+";

public RoomsClientLiveTestBase(bool isAsync) : base(isAsync)
{
Expand Down
7 changes: 2 additions & 5 deletions sdk/core/Azure.Core.TestFramework/src/ClientTestBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,9 @@ public abstract class ClientTestBase
private static readonly IInterceptor s_avoidSyncInterceptor = new UseSyncMethodsInterceptor(forceSync: false);
private static readonly IInterceptor s_diagnosticScopeValidatingInterceptor = new DiagnosticScopeValidatingInterceptor();
private static Dictionary<Type, Exception> s_clientValidation = new Dictionary<Type, Exception>();
#if NETFRAMEWORK

private const int GLOBAL_TEST_TIMEOUT_IN_SECONDS = 15;
#else
private const int GLOBAL_TEST_TIMEOUT_IN_SECONDS = 10;
#endif
private const int GLOBAL_LOCAL_TEST_TIMEOUT_IN_SECONDS = 5;
private const int GLOBAL_LOCAL_TEST_TIMEOUT_IN_SECONDS = 10;
public bool IsAsync { get; }

public bool TestDiagnostics { get; set; } = true;
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.