Skip to content

Commit

Permalink
Use Common Sanitizers (#43660)
Browse files Browse the repository at this point in the history
* target version of proxy with common sanitizers. update startup for the universal output

* target version of proxy with updated common sanitizers

* Remove id sanitizer

* remove start arg

* Update the proxy version to one that is incapable of outputting to
stderr

* testing removal of sanitizers

* target newest version of the proxy

* newer test proxy with proper defaulting of default sanitizers for principalId and clientId

* pin the correct version of the proxy

* storage

* use base64 key

* fix communication

* to/from

* friendlyname

* metrics advisor

* remove redacted

* copy source

* newest proxy version. updating UserDelegationKey.SignedTid/SignedOid to empty guids. UserDelegation key VALUE to 0 in base64 (MA==), and reduction in activity of SAS URI sanitizer to just sig

* storage sanitizers

* cache guid string

* cache empty guid string

* mark attestation as liveonly

* bump to newest version of the proxy. stderr is ENABLED on this proxy instance

* default the proxy to boot without output to stderr

* ARM tests

* eh

* sasUri and x-ms-request-id

* df

* more arm

* Increase timeout due to more sanitizers being used

* fix pattern

* fix patterns

* clean up

* clean up and mark lab test liveonly

* newest version of the proxy

* use newest proxy with adjustments to token replacement

* Update eng/Packages.Data.props

* ensure that all uses of regex globbing are +, add missing + to token regex

* token

* operation location

* clean

* df

* remove LiveOnly from KV

* remove additional unnecessary liveonly usages

* workloads

* mark recordedtest

* liveonly

* try a version of the proxy that has slightly adjusted local caching

* Exclude search sanitizer

* fix pattern

* ignore token sanitizer for search

---------

Co-authored-by: jolov <jolov@microsoft.com>
Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
  • Loading branch information
3 people committed May 8, 2024
1 parent 61bb11a commit 057d2a4
Show file tree
Hide file tree
Showing 36 changed files with 288 additions and 175 deletions.
2 changes: 1 addition & 1 deletion eng/Packages.Data.props
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@
</ItemGroup>

<PropertyGroup>
<TestProxyVersion>1.0.0-dev.20240410.2</TestProxyVersion>
<TestProxyVersion>1.0.0-dev.20240507.1</TestProxyVersion>
</PropertyGroup>

</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

namespace Azure.Security.Attestation.Tests
{
[LiveOnly(Reason = "JWT cannot be stored in recordings.")]
public class AttestationTests : RecordedTestBase<AttestationClientTestEnvironment>
{
// A Base64Url encoded pre-canned OpenEnclave Report, used to test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

namespace Azure.Security.Attestation.Tests
{
[LiveOnly(Reason = "JWT cannot be stored in recordings.")]
public class PolicyGetSetTests : RecordedTestBase<AttestationClientTestEnvironment>
{
public PolicyGetSetTests(bool isAsync) : base(isAsync)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public ProgrammableConnectivityClientTest(bool isAsync) : base(isAsync, Recorded
{
HeaderRegexSanitizers.Add(
new HeaderRegexSanitizer("apc-gateway-id", "**********/resourceGroups")
{ Regex = @"[A-Za-z0-9-\-]*/resourceGroups" });
{ Regex = @"[A-Za-z0-9-\-]+/resourceGroups" });
credential = TestEnvironment.Credential;
}

Expand Down
2 changes: 1 addition & 1 deletion sdk/communication/Azure.Communication.Rooms/assets.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "net",
"TagPrefix": "net/communication/Azure.Communication.Rooms",
"Tag": "net/communication/Azure.Communication.Rooms_b68cae7b87"
"Tag": "net/communication/Azure.Communication.Rooms_2bf926f910"
}
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public class RoomsClientLiveTestBase : RecordedTestBase<RoomsClientTestEnvironme
private const string DateTimeStampRegEx = @"[0-9]*-[0-9]*-[0-9]*T[0-9]*:[0-9]*:[0-9]*.[0-9]*Z";
private const string URIDomainNameReplacerRegEx = @"https://([^/?]+)";
private const string URIIdentityReplacerRegEx = @"/identities/([^/?]+)";
private const string URIRoomsIdReplacerRegEx = @"/rooms/\d*";
private const string URIRoomsIdReplacerRegEx = @"/rooms/\d+";

public RoomsClientLiveTestBase(bool isAsync) : base(isAsync)
{
Expand Down
7 changes: 2 additions & 5 deletions sdk/core/Azure.Core.TestFramework/src/ClientTestBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,9 @@ public abstract class ClientTestBase
private static readonly IInterceptor s_avoidSyncInterceptor = new UseSyncMethodsInterceptor(forceSync: false);
private static readonly IInterceptor s_diagnosticScopeValidatingInterceptor = new DiagnosticScopeValidatingInterceptor();
private static Dictionary<Type, Exception> s_clientValidation = new Dictionary<Type, Exception>();
#if NETFRAMEWORK

private const int GLOBAL_TEST_TIMEOUT_IN_SECONDS = 15;
#else
private const int GLOBAL_TEST_TIMEOUT_IN_SECONDS = 10;
#endif
private const int GLOBAL_LOCAL_TEST_TIMEOUT_IN_SECONDS = 5;
private const int GLOBAL_LOCAL_TEST_TIMEOUT_IN_SECONDS = 10;
public bool IsAsync { get; }

public bool TestDiagnostics { get; set; } = true;
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 057d2a4

Please sign in to comment.