Use Common Sanitizers #29471
Closed
Use Common Sanitizers #29471
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbedd
requested review from
ckairen,
mikeharder,
weshaggard and
benbp
as code owners
24 tasks
scbedd
commented
May 9, 2024
|
Closing. Supplanted by #29655. |
HarshaNalluru
added a commit
that referenced
this pull request
May 14, 2024
## What's happening? - [x] Get Scott's test-proxy version from #29471 - [x] Update `recorder 3.5.0` with - [x] Central Sanitizers - [x] /removeSanitizers API - [x] remove fallback sanitizers - [x] Publish `recorder 3.5.0` - [x] Update `recorder 4.x` with the `recorder 3.5.0` changes and make sure they are in sync. - [x] Update lock file with `rush update --full` to get latest recorder and test-credential packages - [x] Test/fix packages - [x] recorder - [x] storage - [x] template - [x] '@azure-rest/synapse-access-control' - [x] '@azure/arm-resources' - [x] arm-links - [x] arm-resources - [x] event-grid - [x] template-dpg - [x] synpase packages - [ ] '@azure/identity' (future PR) - [x] '@azure/arm-eventgrid' - [x] '@azure/ai-text-analytics' ## Future Work - [ ] Figure out identity tests/recordings - [ ] Make sure CI pipelines for each of the services that are not triggered in this PR get to green by either re-recording or tweaking the recorder config for the package --------- Co-authored-by: Scott Beddall (from Dev Box) <scbedd@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@HarshaNalluru FYI.
Feel free to commit any fixes to recordings or test frameworks to this branch. If you need updates to the proxy version we just need to update
target_proxy_version.txt. I'll worry about rolling out the eng/common updates to version AFTER you're satisfied with how everything is running.