Use Common Sanitizers #39935
Draft
Use Common Sanitizers #39935
+635
−325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run java - core - ci |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run java - core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
scbedd
commented
May 6, 2024
|
/azp run java - core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
samvaity
force-pushed
the
target-common-sanitizers-proxy
branch
from
ddfa8ed
to
4f96094
Compare
|
/azp run java - core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
API change check API changes are not detected in this pull request. |
samvaity
force-pushed
the
target-common-sanitizers-proxy
branch
from
2c17c6c
to
1df09f3
Compare
samvaity
force-pushed
the
target-common-sanitizers-proxy
branch
from
1c3e26b
to
a67c5c4
Compare
samvaity
force-pushed
the
target-common-sanitizers-proxy
branch
from
0b6c92d
to
7436429
Compare
samvaity
force-pushed
the
target-common-sanitizers-proxy
branch
from
7436429
to
03c87d4
Compare
samvaity
force-pushed
the
target-common-sanitizers-proxy
branch
from
1a52309
to
854c06f
Compare
samvaity
force-pushed
the
target-common-sanitizers-proxy
branch
from
1864d7c
to
4083ab5
Compare
jairmyree
reviewed
May 15, 2024
sdk/core/azure-core-test/src/main/java/com/azure/core/test/InterceptorManager.java
Show resolved
Hide resolved
|
@samvaity After testing it seems that currently the logic of this PR does not allow for removal of sanitizers during record, but the javadoc suggests this should be possible. |
samvaity
force-pushed
the
target-common-sanitizers-proxy
branch
2 times, most recently
from
9899f3a
to
11deb2f
Compare
samvaity
force-pushed
the
target-common-sanitizers-proxy
branch
from
11deb2f
to
d4f92f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @billwert @samvaity
If you need a new proxy version with changes. Sing out, we'll just update the
target_proxy_version.txtuntil we're happy with the outcome.Follow up for search SDK tests: #40141