Tracing: redact query params in urls #39925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
requested review from
trask,
alzimmermsft,
srnagar,
anuchandy,
vcolin7,
mssfang,
JonathanGiles and
billwert
as code owners
github-actions
bot
added
Azure.Core
|
API change check API changes are not detected in this pull request. |
lmolkova
commented
Apr 29, 2024
sdk/core/azure-core/src/main/java/com/azure/core/http/policy/HttpLoggingPolicy.java
Show resolved
Hide resolved
srnagar
approved these changes
Apr 29, 2024
sdk/core/azure-core/src/main/java/com/azure/core/http/HttpPipelineBuilder.java
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/implementation/http/policy/UrlSanitizer.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/implementation/http/policy/UrlSanitizer.java
Outdated
Show resolved
Hide resolved
alzimmermsft
approved these changes
Apr 29, 2024
sdk/core/azure-core/src/main/java/com/azure/core/implementation/http/policy/UrlSanitizer.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't sanitize URLs for tracing purposes. Fixing it:
It also includes a small refactoring in
HttpLoggingPolicyand removes double-logging of content-length if headers are enabled.