Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Messaging (Event Hubs, Service Bus) logging improvements #39904

Merged
merged 13 commits into from Apr 30, 2024
Merged

Messaging (Event Hubs, Service Bus) logging improvements #39904

merged 13 commits into from Apr 30, 2024

Conversation

lmolkova
Copy link
Member

@lmolkova lmolkova commented Apr 24, 2024 •
edited

Fixes #39575

  • logs transient issues as warnings (instead of errors)
  • logs issues when something is already closed or disposed as warnings (instead of errors)
  • logs terminal issues as errors (if they aren't)

Removes some deprecated (a long time ago) internal, unused constructors.

@lmolkova lmolkova mentioned this pull request Apr 24, 2024
Closed
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@anuchandy anuchandy changed the title ServceBus logging improvements Messaging (Event Hubs, Service Bus) logging improvements Apr 24, 2024
anuchandy
anuchandy reviewed Apr 24, 2024
View reviewed changes
Copy link
Member

@anuchandy anuchandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Liudmila, I don’t think with the changes so far we miss any logs that is crucial for incident investigations. Just some minor comments to hear your thoughts

...e/azure-core-amqp/src/main/java/com/azure/core/amqp/implementation/AmqpChannelProcessor.java Show resolved Hide resolved
sdk/core/azure-core-amqp/src/main/java/com/azure/core/amqp/implementation/MessageFlux.java Outdated Show resolved Hide resolved
...azure-core-amqp/src/main/java/com/azure/core/amqp/implementation/ReactorConnectionCache.java Show resolved Hide resolved
...core/azure-core-amqp/src/main/java/com/azure/core/amqp/implementation/ReactorDispatcher.java Outdated Show resolved Hide resolved
...c/main/java/com/azure/core/amqp/implementation/handler/WebSocketsProxyConnectionHandler.java Show resolved Hide resolved
...e/azure-core-amqp/src/main/java/com/azure/core/amqp/implementation/AmqpChannelProcessor.java Outdated Show resolved Hide resolved
@lmolkova lmolkova force-pushed the servcebus-logs-transient-as-warning branch from cf49232 to eb6fcfa Compare April 29, 2024 20:28
anuchandy
anuchandy approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@anuchandy anuchandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, LGTM!

sdk/servicebus/azure-messaging-servicebus-stress/pom.xml Outdated Show resolved Hide resolved
@lmolkova lmolkova enabled auto-merge (squash) April 30, 2024 20:03
@lmolkova lmolkova merged commit d773bdf into Azure:main Apr 30, 2024
50 checks passed
@anuchandy anuchandy mentioned this pull request May 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuchandy anuchandy anuchandy approved these changes

@conniey conniey Awaiting requested review from conniey conniey is a code owner

Assignees
No one assigned
Labels
Azure.Core.AMQP azure-core-amqp Service Bus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Service bus sender client: connection errors in logs
3 participants
@lmolkova @azure-sdk @anuchandy