Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cosmos][VectorSearch] Non Streaming Order By Query #39897
[Cosmos][VectorSearch] Non Streaming Order By Query #39897
Changes from 26 commits
540a16d
6f49c75
97509eb
528a0eb
86b36d3
a979c11
e2756a5
8be2277
e491b9d
151bb50
73afd5b
148cba5
3b0d751
87572f7
df7e838
179f904
5602e33
36ab9b7
70639b5
c45c3a5
6c255ee
9d427e6
1cadb1b
0f1be0c
d4dcad2
cdaa5bc
dfa8b64
7549cbe
c6e2376
30d8370
8279358
dd9d13b
d966af4
9eb9208
1aaecef
8bf4f8d
943cc4c
1db9b31
2770b0f
7002362
508e94a
822bd67
46fe7cb
5657b75
015a77c
f87be45
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
split handling?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it uses
produceAsync
from the baseDocumentProducer
which is split-proof.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But during
createChildDocumentProducerOnSplit
, when creating the child documentProducer, should we createNonStreamingOrderByDocumentProducer
? By default, it only createsDocumentProducer
@aayush3011 can we add a split tests to verify? thanks