design, validate parameters in Builder

[weidongxu-microsoft]

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

• The pull request does not introduce [breaking changes]
• CHANGELOG is updated for new features, bug fixes or other significant changes.
• I have read the contribution guidelines.

General Guidelines and Best Practices

• Title of the pull request is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

• Pull request includes test coverage for the included changes.

[weidongxu-microsoft]

The change on endpoint would apply to any required client properties.

discussion

1. Should we use a different exception, e.g. InvalidStateException?
2. Do we put these "default validation" here, or in createHttpPipeline (so that the whole method is generated as empty and intended for customization)?

[billwert]

InvalidStateException seems most correct to me.

I think I'm in favor of leaving all of the validation in this method. Perhaps we generate a comment that these are the default requirements and others can be added? "Magic" other validation seems hard to understand.

[azure-sdk]

API change check

API changes are not detected in this pull request.

[billwert]

Why here and not in buildInnerClient? It doesn't matter much in this example; are there others where it might matter more?

[weidongxu-microsoft]

An alternative code flow would be user setting the pipeline via

azure-sdk-for-java/sdk/contentsafety/azure-ai-contentsafety/src/main/java/com/azure/ai/contentsafety/ContentSafetyClientBuilder.java

Line 88 in 020a2a6

public ContentSafetyClientBuilder pipeline(HttpPipeline pipeline) {

And builderInnerClient has this

azure-sdk-for-java/sdk/contentsafety/azure-ai-contentsafety/src/main/java/com/azure/ai/contentsafety/ContentSafetyClientBuilder.java

Lines 278 to 279 in 020a2a6

	private ContentSafetyClientImpl buildInnerClient() {
	HttpPipeline localPipeline = (pipeline != null) ? pipeline : createHttpPipeline();

(createHttpPipeline won't be called, if user provides the pipeline)

I think in that code flow, there is no need to verify anything (as user provides a pipeline and we cannot inspect it anyway).