Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[clientcore] Logging with optional slf4j #39837

Merged
merged 13 commits into from
May 9, 2024
Merged

[clientcore] Logging with optional slf4j #39837

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
975c411
model
lmolkova Apr 20, 2024
fc2a448
slf4j via reflection
lmolkova Apr 21, 2024
8b0b59c
clean up
lmolkova Apr 21, 2024
eee77b0
Replaced `Method` with `MethodHandle` in `Slf4jLoggerShim`.
vcolin7 May 1, 2024
d4a1dab
Fixed formatting.
vcolin7 May 1, 2024
1836b78
Minor test code cleanup.
vcolin7 May 1, 2024
41efbd1
Cleaned up code.
vcolin7 May 1, 2024
8f28f6f
Fixed invocation of the logging methods from the `Logger` interface.
vcolin7 May 1, 2024
a2c41ed
Minor code renames.
vcolin7 May 1, 2024
be92deb
Made the default logger log only when no SLF4J instance can be created.
vcolin7 May 1, 2024
b0549bd
Address some review comments
lmolkova May 2, 2024
8a09194
add default logger marker to errors
lmolkova May 2, 2024
9710342
core review
lmolkova May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 0 additions & 8 deletions sdk/client-core/core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,11 +86,6 @@
<artifactId>core-json</artifactId>
<version>1.0.0-beta.1</version> <!-- {x-version-update;io.clientcore:core-json;dependency} -->
</dependency>
<dependency>
alzimmermsft marked this conversation as resolved.
Show resolved Hide resolved
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
<version>1.7.36</version> <!-- {x-version-update;org.slf4j:slf4j-api;external_dependency} -->
</dependency>

<!-- Test dependencies -->
<dependency>
Expand Down Expand Up @@ -169,9 +164,6 @@
<configuration>
<rules>
<bannedDependencies>
<includes>
<include>org.slf4j:slf4j-api:[1.7.36]</include> <!-- {x-include-update;org.slf4j:slf4j-api;external_dependency} -->
</includes>
</bannedDependencies>
</rules>
</configuration>
Expand Down