New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imagebuilder API Release 2024-02-01 #28871
base: main
Are you sure you want to change the base?
Imagebuilder API Release 2024-02-01 #28871
Conversation
Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from stable/2023-07-01 to stable/2024-02-01.
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Validation Report
|
Rule | Message |
---|---|
Runtime Exception |
"new":"https://github.com/Azure/azure-rest-api-specs/blob/a9d65a190f43088ee76033dcf5bdc9baac570432/specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2023-07-01/imagebuilder.json", "details":"Breaking change detector (OAD) invoked AutoRest. AutoRest threw a runtime error. First 20 lines of stack trace follow, indexed. First line should contain AutoRest command line invocation details. Remaining lines should contain the main message reported by AutoRest. ==================== 1: Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.97/common/temp/node_modules/.pnpm/@Azure+oad@0.10.8/node_modules/autorest/dist/app.js" --v2 --input-file=specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp/oad-wGNbIk 2: ERROR: Referenced file 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2024-02-01/examples/OperationsList.json' not found 3: - file:///mnt/vss/_work/1/azure-rest-api-specs/specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json:755:12 ($.paths["/providers/Microsoft.VirtualMachineImages/operations"].get["x-ms-examples"]["Retrieve operations list"]["$ref"]) 4: FATAL: swagger-document/loader - FAILED 5: FATAL: Error: [OperationAbortedException] Error occurred. Exiting. 6: Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting." |
The following breaking changes are detected by comparison with the latest preview version:
Rule | Message |
---|---|
Runtime Exception |
"new":"https://github.com/Azure/azure-rest-api-specs/blob/a9d65a190f43088ee76033dcf5bdc9baac570432/specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/preview/2019-05-01-preview/imagebuilder.json", "details":"Breaking change detector (OAD) invoked AutoRest. AutoRest threw a runtime error. First 20 lines of stack trace follow, indexed. First line should contain AutoRest command line invocation details. Remaining lines should contain the main message reported by AutoRest. ==================== 1: Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.97/common/temp/node_modules/.pnpm/@Azure+oad@0.10.8/node_modules/autorest/dist/app.js" --v2 --input-file=specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp/oad-htq9yl 2: ERROR: Referenced file 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2024-02-01/examples/OperationsList.json' not found 3: - file:///mnt/vss/_work/1/azure-rest-api-specs/specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json:755:12 ($.paths["/providers/Microsoft.VirtualMachineImages/operations"].get["x-ms-examples"]["Retrieve operations list"]["$ref"]) 4: FATAL: swagger-document/loader - FAILED 5: FATAL: Error: [OperationAbortedException] Error occurred. Exiting. 6: Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting." |
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌
LintDiff: 20 Errors, 0 Warnings failed [Detail]
Compared specs (v2.2.0) | new version | base version |
---|---|---|
package-2024-02 | package-2024-02(a9d65a1) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Rule | Message | Related RPC [For API reviewers] |
---|---|---|
invalid-ref |
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2024-02-01/examples/ListImageTemplates.json . Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L70 |
|
invalid-ref |
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2024-02-01/examples/ListImageTemplatesByRg.json . Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L112 |
|
invalid-ref |
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2024-02-01/examples/CreateImageTemplateLinux.json . Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L173 |
|
invalid-ref |
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2024-02-01/examples/CreateImageTemplateWindows.json . Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L176 |
|
invalid-ref |
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2024-02-01/examples/UpdateImageTemplateTags.json . Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L232 |
|
invalid-ref |
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2024-02-01/examples/UpdateImageTemplateToRemoveIdentities.json . Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L235 |
|
invalid-ref |
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2024-02-01/examples/GetImageTemplate.json . Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L275 |
|
invalid-ref |
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2024-02-01/examples/DeleteImageTemplate.json . Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L325 |
|
invalid-ref |
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2024-02-01/examples/RunImageTemplate.json . Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L374 |
|
invalid-ref |
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2024-02-01/examples/CancelImageBuild.json . Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L423 |
|
invalid-ref |
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2024-02-01/examples/ListRunOutputs.json . Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L468 |
|
invalid-ref |
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2024-02-01/examples/GetRunOutput.json . Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L513 |
|
invalid-ref |
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2024-02-01/examples/ListTriggers.json . Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L558 |
|
invalid-ref |
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2024-02-01/examples/GetTrigger.json . Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L603 |
|
invalid-ref |
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2024-02-01/examples/CreateSourceImageTrigger.json . Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L665 |
|
invalid-ref |
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2024-02-01/examples/DeleteTrigger.json . Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L718 |
|
invalid-ref |
Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2024-02-01/examples/OperationsList.json . Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L754 |
|
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L769 |
RPC-Policy-V1-05, RPC-Put-V1-23 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L1655 |
RPC-Policy-V1-05, RPC-Put-V1-23 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L1741 |
RPC-Policy-V1-05, RPC-Put-V1-23 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L151 |
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L157 |
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L213 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L217 |
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L263 |
PostResponseCodes |
Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L332 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L359 |
PostResponseCodes |
Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L381 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L408 |
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L501 |
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L591 |
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L643 |
ProvisioningStateMustBeReadOnly |
provisioningState property must be set to readOnly. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L649 |
OperationsApiSchemaUsesCommonTypes |
Operations API path must follow the schema provided in the common types. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L740 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L769 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L1175 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L1193 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L1217 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L1287 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L1593 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L1694 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L1741 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L1780 |
XmsParameterLocation |
The parameter 'SubscriptionIdParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L2034 |
XmsParameterLocation |
The parameter 'ApiVersionParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L2084 |
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L945 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L950 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L1116 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L1121 |
|
Property location must have 'x-ms-mutability':['read', 'create'] extension defined.Location: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L1202 |
️❌
Avocado: 1 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
NO_JSON_FILE_FOUND |
The JSON file is not found but it is referenced from the readme file. readme: specification/imagebuilder/resource-manager/readme.md json: stable/2024-02-01/examples/OperationsList.json |
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️❌
ModelValidation: 1 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
unacceptable kind of an object to dump [object Error] |
"role":"Model Validation", "url":"https://github.com/Azure/azure-rest-api-specs/blob/a9d65a190f43088ee76033dcf5bdc9baac570432/specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json" |
️❌
SemanticValidation: 1 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
INTERNAL_ERROR |
Unexpected internal error: ENOENT: no such file or directory, open '/mnt/vss/_work/1/azure-rest-api-specs/specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2024-02-01/examples/ListImageTemplates.json' Error: ENOENT: no such file or directory, open '/mnt/vss/_work/1/azure-rest-api-specs/specification/imagebuilder/resource-manager/Microsoft.VirtualMachineImages/stable/2024-02-01/examples/ListImageTemplates.json' JsonUrl: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json |
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️❌
SpellCheck: 2 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
HowToFix |
Unknown word (Autorun), please fix the error. See https://aka.ms/ci-fix#spell-check path: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L1513:33 |
HowToFix |
Unknown word (Autorun), please fix the error. See https://aka.ms/ci-fix#spell-check path: Microsoft.VirtualMachineImages/stable/2024-02-01/imagebuilder.json#L1518:33 |
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Hi @zdelacerda-microsoft, this service has enabled ShiftLeft Toolset. All spec updates MUST be initiated from service ADO project repo, so that to guarantee it to be the source of truth., please review this pull request if it is intentional or reject it if it is not expected. Normally, all the specification or example changes should start with PR created in ADO. |
Swagger Generation Artifacts
|
Generated ApiView
|
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.Note
As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1, Breaking Changes review
If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.
Click here to see the details of Step 2, ARM review
See https://aka.ms/azsdk/pr-arm-review.
Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.Next Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.