Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Private Only Feature #28834

Draft
wants to merge 4 commits into
base: release-network-Microsoft.Network-2024-01-01
Choose a base branch
from
Draft

Add Private Only Feature #28834

wants to merge 4 commits into from

Conversation

zhaochongliu
Copy link

@zhaochongliu zhaochongliu commented Apr 24, 2024 •
edited

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1, Breaking Changes review

If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.

Click here to see the details of Step 2, ARM review

See https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Abhishek Shah and others added 2 commits April 22, 2024 14:20
@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Apr 24, 2024
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

Thank you for your contribution zhaochongliu! We will review the pull request and get back to you soon.

@zhaochongliu zhaochongliu marked this pull request as ready for review April 24, 2024 13:04
@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Apr 24, 2024 •
edited

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR is in purview of ARM review (label: ARMReview). Please ensure your PR is on the ARM PR review queue - see instructions in steps 1 and 2 in the PR description diagram.
  • ❌ The required check named Swagger LintDiff has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it.

@openapi-pipeline-app openapi-pipeline-app
Copy link

PR validation pipeline started successfully. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

@openapi-pipeline-app openapi-pipeline-app
Copy link

PR validation pipeline started successfully. This comment will be populated with the 'Swagger Validation Report'

@openapi-pipeline-app openapi-pipeline-app
Copy link

PR validation pipeline started successfully. This comment will be populated with the 'Swagger Generation Artifacts' report

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Apr 24, 2024 •
edited

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand] 
There are no breaking changes.
️❌Breaking Change(Cross-Version): 1 Errors, 0 Warnings failed [Detail]
Compared specs (v0.10.8) new version base version
bastionHost.json 2024-01-01(25f0004) 2023-11-01(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule Message
❌ 1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
New: Microsoft.Network/stable/2024-01-01/bastionHost.json#L792:7
Old: Microsoft.Network/stable/2023-11-01/bastionHost.json#L676:7
️❌LintDiff: 15 Errors, 3 Warnings failed [Detail]
Compared specs (v2.2.0) new version base version
package-2024-01 package-2024-01(25f0004) package-2024-01(release-network-Microsoft.Network-2024-01-01)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/applicationGateway.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/25f0004a7e4f763c40363f2cbea7f83180462a97/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/dscpConfiguration.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/25f0004a7e4f763c40363f2cbea7f83180462a97/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/loadBalancer.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/25f0004a7e4f763c40363f2cbea7f83180462a97/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/networkInterface.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/25f0004a7e4f763c40363f2cbea7f83180462a97/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/networkProfile.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/25f0004a7e4f763c40363f2cbea7f83180462a97/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/networkSecurityGroup.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/25f0004a7e4f763c40363f2cbea7f83180462a97/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/privateEndpoint.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/25f0004a7e4f763c40363f2cbea7f83180462a97/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/privateLinkService.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/25f0004a7e4f763c40363f2cbea7f83180462a97/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/publicIpAddress.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/25f0004a7e4f763c40363f2cbea7f83180462a97/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/routeTable.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/25f0004a7e4f763c40363f2cbea7f83180462a97/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/serviceEndpointPolicy.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/25f0004a7e4f763c40363f2cbea7f83180462a97/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/virtualNetwork.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/25f0004a7e4f763c40363f2cbea7f83180462a97/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/virtualNetworkTap.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/25f0004a7e4f763c40363f2cbea7f83180462a97/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/virtualWan.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/25f0004a7e4f763c40363f2cbea7f83180462a97/#L1
❌ FATAL spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/webapplicationfirewall.json'. Errors encountered: TypeError: Cannot read properties of null (reading 'additionalProperties')
Location: azure-rest-api-specs/blob/25f0004a7e4f763c40363f2cbea7f83180462a97/#L1
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L652
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L712
⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L1184


The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L38
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L59
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L235
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L369
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L394
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L422
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L572
❌ MissingTypeObject The schema 'BastionHostIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L791
❌ MissingTypeObject The schema 'BastionHostIPConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L816
❌ MissingTypeObject The schema 'BastionHostPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L845
❌ MissingTypeObject The schema 'networkAcls' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L862
❌ MissingTypeObject The schema 'BastionHost' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L929
❌ MissingTypeObject The schema 'BastionHostListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L960
❌ MissingTypeObject The schema 'BastionShareableLink' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L976
❌ MissingTypeObject The schema 'BastionShareableLinkListRequest' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L1003
❌ MissingTypeObject The schema 'BastionShareableLinkListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L1028
❌ MissingTypeObject The schema 'BastionActiveSession' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L1044
❌ MissingTypeObject The schema 'BastionActiveSessionListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L1112
❌ MissingTypeObject The schema 'BastionSessionState' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L1128
❌ MissingTypeObject The schema 'BastionSessionDeleteResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L1148
❌ MissingTypeObject The schema 'SessionIds' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L1172
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L44
⚠️ RequiredReadOnlySystemData The response of operation:'BastionHosts_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L88
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L94
⚠️ RequiredReadOnlySystemData The response of operation:'BastionHosts_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L134
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L140
⚠️ RequiredReadOnlySystemData The response of operation:'BastionHosts_UpdateTags' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L199
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L205
⚠️ PatchSkuProperty The patch operation body parameter schema should contain property 'sku'.
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L215
⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
Location: Microsoft.Network/stable/2024-01-01/bastionHost.json#L263
️❌Avocado: 2 Errors, 0 Warnings failed [Detail]
Rule Message
❌ UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/network/resource-manager/readme.md
json: stable/2024-01-01/examples/BastionHostGetWithPrivateOnly.json
❌ UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/network/resource-manager/readme.md
json: stable/2024-01-01/examples/BastionHostPutWithPrivateOnly.json
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand] 
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand] 
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand] 
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app openapi-pipeline-app
Copy link

PR validation pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Apr 24, 2024 •
edited

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand] 
 Please click here to preview with your @microsoft account.
️❌ azure-sdk-for-net failed [Detail]
  • ❌Code Generator Failed in generating from fa18bf0. SDK Automation 14.0.0 
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.101 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
  • ❌Microsoft.Azure.Management.Network [Preview SDK Changes] 
    cmdout	[msbuild] /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkTap.cs(148,60): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard1.4]
cmdout	[msbuild]      1>/home/cloudtest/.nuget/packages/microsoft.internal.netsdkbuild.mgmt.tools/0.12.0-dev.20220216.1/targets/common.targets(119,5): error MSB4181: The "MSBuild" task returned false but did not log an error. [/mnt/vss/_work/1/s/azure-sdk-for-net/eng/mgmt.proj]
cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkTap.cs(148,60): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard1.4]
cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/InboundNatRule.cs(238,40): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard1.4]
cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/ApplicationGatewayBackendHealthServer.cs(89,33): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard1.4]
cmdout	[msbuild]          /home/cloudtest/.nuget/packages/microsoft.internal.netsdkbuild.mgmt.tools/0.12.0-dev.20220216.1/targets/common.targets(119,5): error MSB4181: The "MSBuild" task returned false but did not log an error. [/mnt/vss/_work/1/s/azure-sdk-for-net/eng/mgmt.proj]
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from fa18bf0. SDK Automation 14.0.0 
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
  • ️✔️Azure.ResourceManager.Network [Preview SDK Changes]
    • Azure.ResourceManager.Network.1.8.0-alpha.20240424.1.nupkg
    info	[Changelog]
️🔄 azure-sdk-for-python inProgress [Detail]
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning in generating from fa18bf0. SDK Automation 14.0.0 
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh]
cmderr	[init.sh] npm notice New patch version of npm available! 10.5.0 -> 10.5.2
cmderr	[init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.2>
cmderr	[init.sh] npm notice Run `npm install -g npm@10.5.2` to update!
cmderr	[init.sh] npm notice
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-network-generated [Preview SDK Changes]
    • pom.xml
    • azure-resourcemanager-network-generated-1.0.0-beta.1.jar
    • azure-resourcemanager-network-generated-1.0.0-beta.1-sources.jar
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from fa18bf0. SDK Automation 14.0.0 
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/network/armnetwork [Preview SDK Changes] 
    info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `BastionHostSKUNamePremium` added to enum type `BastionHostSKUName`
info	[Changelog] - New value `EndpointTypeAzureArcNetwork` added to enum type `EndpointType`
info	[Changelog] - New enum type `ApplicationGatewaySKUFamily` with values `ApplicationGatewaySKUFamilyGeneration1`, `ApplicationGatewaySKUFamilyGeneration2`
info	[Changelog] - New enum type `InboundSecurityRuleType` with values `InboundSecurityRuleTypeAutoExpire`, `InboundSecurityRuleTypePermanent`
info	[Changelog] - New enum type `NicTypeInRequest` with values `NicTypeInRequestPrivateNic`, `NicTypeInRequestPublicNic`
info	[Changelog] - New enum type `NicTypeInResponse` with values `NicTypeInResponseAdditionalNic`, `NicTypeInResponsePrivateNic`, `NicTypeInResponsePublicNic`
info	[Changelog] - New enum type `SharingScope` with values `SharingScopeDelegatedServices`, `SharingScopeTenant`
info	[Changelog] - New function `*ClientFactory.NewFirewallPolicyDeploymentsClient() *FirewallPolicyDeploymentsClient`
info	[Changelog] - New function `*ClientFactory.NewFirewallPolicyDraftsClient() *FirewallPolicyDraftsClient`
info	[Changelog] - New function `*ClientFactory.NewFirewallPolicyRuleCollectionGroupDraftsClient() *FirewallPolicyRuleCollectionGroupDraftsClient`
info	[Changelog] - New function `NewFirewallPolicyDeploymentsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FirewallPolicyDeploymentsClient, error)`
info	[Changelog] - New function `*FirewallPolicyDeploymentsClient.BeginDeploy(context.Context, string, string, *FirewallPolicyDeploymentsClientBeginDeployOptions) (*runtime.Poller[FirewallPolicyDeploymentsClientDeployResponse], error)`
info	[Changelog] - New function `NewFirewallPolicyDraftsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FirewallPolicyDraftsClient, error)`
info	[Changelog] - New function `*FirewallPolicyDraftsClient.CreateOrUpdate(context.Context, string, string, FirewallPolicyDraft, *FirewallPolicyDraftsClientCreateOrUpdateOptions) (FirewallPolicyDraftsClientCreateOrUpdateResponse, error)`
info	[Changelog] - New function `*FirewallPolicyDraftsClient.Delete(context.Context, string, string, *FirewallPolicyDraftsClientDeleteOptions) (FirewallPolicyDraftsClientDeleteResponse, error)`
info	[Changelog] - New function `*FirewallPolicyDraftsClient.Get(context.Context, string, string, *FirewallPolicyDraftsClientGetOptions) (FirewallPolicyDraftsClientGetResponse, error)`
info	[Changelog] - New function `NewFirewallPolicyRuleCollectionGroupDraftsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FirewallPolicyRuleCollectionGroupDraftsClient, error)`
info	[Changelog] - New function `*FirewallPolicyRuleCollectionGroupDraftsClient.CreateOrUpdate(context.Context, string, string, string, FirewallPolicyRuleCollectionGroupDraft, *FirewallPolicyRuleCollectionGroupDraftsClientCreateOrUpdateOptions) (FirewallPolicyRuleCollectionGroupDraftsClientCreateOrUpdateResponse, error)`
info	[Changelog] - New function `*FirewallPolicyRuleCollectionGroupDraftsClient.Delete(context.Context, string, string, string, *FirewallPolicyRuleCollectionGroupDraftsClientDeleteOptions) (FirewallPolicyRuleCollectionGroupDraftsClientDeleteResponse, error)`
info	[Changelog] - New function `*FirewallPolicyRuleCollectionGroupDraftsClient.Get(context.Context, string, string, string, *FirewallPolicyRuleCollectionGroupDraftsClientGetOptions) (FirewallPolicyRuleCollectionGroupDraftsClientGetResponse, error)`
info	[Changelog] - New function `*ManagementClient.BeginGetSessionRecordingSasURL(context.Context, string, string, *ManagementClientBeginGetSessionRecordingSasURLOptions) (*runtime.Poller[ManagementClientGetSessionRecordingSasURLResponse], error)`
info	[Changelog] - New function `*ManagementClient.BeginSetSessionRecordingSasURL(context.Context, string, string, string, *ManagementClientBeginSetSessionRecordingSasURLOptions) (*runtime.Poller[ManagementClientSetSessionRecordingSasURLResponse], error)`
info	[Changelog] - New function `*VirtualAppliancesClient.Restart(context.Context, string, string, *VirtualAppliancesClientRestartOptions) (VirtualAppliancesClientRestartResponse, error)`
info	[Changelog] - New struct `ConnectionMonitorEndpointLocationDetails`
info	[Changelog] - New struct `FirewallPolicyDraft`
info	[Changelog] - New struct `FirewallPolicyDraftProperties`
info	[Changelog] - New struct `FirewallPolicyRuleCollectionGroupDraft`
info	[Changelog] - New struct `FirewallPolicyRuleCollectionGroupDraftProperties`
info	[Changelog] - New struct `HeaderValueMatcher`
info	[Changelog] - New struct `PacketCaptureSettings`
info	[Changelog] - New struct `SetSessionRecordingSasURLResponse`
info	[Changelog] - New struct `VirtualApplianceIPConfiguration`
info	[Changelog] - New struct `VirtualApplianceIPConfigurationProperties`
info	[Changelog] - New struct `VirtualApplianceInstanceIDs`
info	[Changelog] - New struct `VirtualApplianceNetworkInterfaceConfiguration`
info	[Changelog] - New struct `VirtualApplianceNetworkInterfaceConfigurationProperties`
info	[Changelog] - New struct `VirtualAppliancePropertiesFormatNetworkProfile`
info	[Changelog] - New field `HeaderValueMatcher` in struct `ApplicationGatewayHeaderConfiguration`
info	[Changelog] - New field `Family` in struct `ApplicationGatewaySKU`
info	[Changelog] - New field `EnablePrivateOnlyBastion`, `EnableSessionRecording` in struct `BastionHostPropertiesFormat`
info	[Changelog] - New field `LocationDetails`, `SubscriptionID` in struct `ConnectionMonitorEndpoint`
info	[Changelog] - New field `EnableDirectPortRateLimit` in struct `ExpressRouteCircuitPropertiesFormat`
info	[Changelog] - New field `Identity` in struct `FlowLog`
info	[Changelog] - New field `Identity` in struct `FlowLogInformation`
info	[Changelog] - New field `RuleType` in struct `InboundSecurityRuleProperties`
info	[Changelog] - New field `AppliesOn`, `DestinationPortRanges`, `Name` in struct `InboundSecurityRules`
info	[Changelog] - New field `PrivateIPAddressPrefixLength` in struct `InterfaceIPConfigurationPropertiesFormat`
info	[Changelog] - New field `CaptureSettings`, `ContinuousCapture` in struct `PacketCaptureParameters`
info	[Changelog] - New field `CaptureSettings`, `ContinuousCapture` in struct `PacketCaptureResultProperties`
info	[Changelog] - New field `LocalPath` in struct `PacketCaptureStorageLocation`
info	[Changelog] - New field `JsChallengeCookieExpirationInMins` in struct `PolicySettings`
info	[Changelog] - New field `SharingScope` in struct `SubnetPropertiesFormat`
info	[Changelog] - New field `DpdTimeoutSeconds` in struct `VPNSiteLinkConnectionProperties`
info	[Changelog] - New field `NicType` in struct `VirtualApplianceNicProperties`
info	[Changelog] - New field `NetworkProfile` in struct `VirtualAppliancePropertiesFormat`
info	[Changelog] - New field `EnableOnlyIPv6Peering`, `LocalAddressSpace`, `LocalSubnetNames`, `LocalVirtualNetworkAddressSpace`, `PeerCompleteVnets`, `RemoteSubnetNames` in struct `VirtualNetworkPeeringPropertiesFormat`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 81 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from fa18bf0. SDK Automation 14.0.0 
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-network [Preview SDK Changes]
    • azure-arm-network-33.2.0.tgz
    info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group FirewallPolicyDeployments
info	[Changelog]   - Added operation group FirewallPolicyDrafts
info	[Changelog]   - Added operation group FirewallPolicyRuleCollectionGroupDrafts
info	[Changelog]   - Added operation NetworkVirtualAppliances.restart
info	[Changelog]   - Added Interface ConnectionMonitorEndpointLocationDetails
info	[Changelog]   - Added Interface FirewallPolicyDeploymentsDeployHeaders
info	[Changelog]   - Added Interface FirewallPolicyDeploymentsDeployOptionalParams
info	[Changelog]   - Added Interface FirewallPolicyDraft
info	[Changelog]   - Added Interface FirewallPolicyDraftsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface FirewallPolicyDraftsDeleteOptionalParams
info	[Changelog]   - Added Interface FirewallPolicyDraftsGetOptionalParams
info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraft
info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraftsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraftsDeleteOptionalParams
info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraftsGetOptionalParams
info	[Changelog]   - Added Interface GetSessionRecordingSasUrlOptionalParams
info	[Changelog]   - Added Interface HeaderValueMatcher
info	[Changelog]   - Added Interface NetworkManagementClientGetSessionRecordingSasUrlHeaders
info	[Changelog]   - Added Interface NetworkManagementClientSetSessionRecordingSasUrlHeaders
info	[Changelog]   - Added Interface NetworkVirtualApplianceInstanceIds
info	[Changelog]   - Added Interface NetworkVirtualAppliancePropertiesFormatNetworkProfile
info	[Changelog]   - Added Interface NetworkVirtualAppliancesRestartOptionalParams
info	[Changelog]   - Added Interface PacketCaptureSettings
info	[Changelog]   - Added Interface SetSessionRecordingSasUrlOptionalParams
info	[Changelog]   - Added Interface SetSessionRecordingSasUrlResponse
info	[Changelog]   - Added Interface VirtualApplianceIPConfiguration
info	[Changelog]   - Added Interface VirtualApplianceIPConfigurationProperties
info	[Changelog]   - Added Interface VirtualApplianceNetworkInterfaceConfiguration
info	[Changelog]   - Added Interface VirtualApplianceNetworkInterfaceConfigurationProperties
info	[Changelog]   - Added Type Alias ApplicationGatewaySkuFamily
info	[Changelog]   - Added Type Alias FirewallPolicyDeploymentsDeployResponse
info	[Changelog]   - Added Type Alias FirewallPolicyDraftsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias FirewallPolicyDraftsGetResponse
info	[Changelog]   - Added Type Alias FirewallPolicyRuleCollectionGroupDraftsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias FirewallPolicyRuleCollectionGroupDraftsGetResponse
info	[Changelog]   - Added Type Alias GetSessionRecordingSasUrlResponse
info	[Changelog]   - Added Type Alias InboundSecurityRuleType
info	[Changelog]   - Added Type Alias NicTypeInRequest
info	[Changelog]   - Added Type Alias NicTypeInResponse
info	[Changelog]   - Added Type Alias SetSessionRecordingSasUrlOperationResponse
info	[Changelog]   - Added Type Alias SharingScope
info	[Changelog]   - Interface ApplicationGatewayHeaderConfiguration has a new optional parameter headerValueMatcher
info	[Changelog]   - Interface ApplicationGatewaySku has a new optional parameter family
info	[Changelog]   - Interface BastionHost has a new optional parameter enablePrivateOnlyBastion
info	[Changelog]   - Interface BastionHost has a new optional parameter enableSessionRecording
info	[Changelog]   - Interface ConnectionMonitorEndpoint has a new optional parameter locationDetails
info	[Changelog]   - Interface ConnectionMonitorEndpoint has a new optional parameter subscriptionId
info	[Changelog]   - Interface ExpressRouteCircuit has a new optional parameter enableDirectPortRateLimit
info	[Changelog]   - Interface FlowLog has a new optional parameter identity
info	[Changelog]   - Interface FlowLogInformation has a new optional parameter identity
info	[Changelog]   - Interface InboundSecurityRule has a new optional parameter ruleType
info	[Changelog]   - Interface InboundSecurityRules has a new optional parameter appliesOn
info	[Changelog]   - Interface InboundSecurityRules has a new optional parameter destinationPortRanges
info	[Changelog]   - Interface InboundSecurityRules has a new optional parameter name
info	[Changelog]   - Interface NetworkInterfaceIPConfiguration has a new optional parameter privateIPAddressPrefixLength
info	[Changelog]   - Interface NetworkVirtualAppliance has a new optional parameter networkProfile
info	[Changelog]   - Interface PacketCapture has a new optional parameter captureSettings
info	[Changelog]   - Interface PacketCapture has a new optional parameter continuousCapture
info	[Changelog]   - Interface PacketCaptureParameters has a new optional parameter captureSettings
info	[Changelog]   - Interface PacketCaptureParameters has a new optional parameter continuousCapture
info	[Changelog]   - Interface PacketCaptureResult has a new optional parameter captureSettings
info	[Changelog]   - Interface PacketCaptureResult has a new optional parameter continuousCapture
info	[Changelog]   - Interface PacketCaptureStorageLocation has a new optional parameter localPath
info	[Changelog]   - Interface PolicySettings has a new optional parameter jsChallengeCookieExpirationInMins
info	[Changelog]   - Interface Subnet has a new optional parameter sharingScope
info	[Changelog]   - Interface VirtualApplianceNicProperties has a new optional parameter nicType
info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter enableOnlyIPv6Peering
info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter localAddressSpace
info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter localSubnetNames
info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter localVirtualNetworkAddressSpace
info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter peerCompleteVnets
info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter remoteSubnetNames
info	[Changelog]   - Interface VpnSiteLinkConnection has a new optional parameter dpdTimeoutSeconds
info	[Changelog]   - Added Enum KnownApplicationGatewaySkuFamily
info	[Changelog]   - Added Enum KnownInboundSecurityRuleType
info	[Changelog]   - Added Enum KnownNicTypeInRequest
info	[Changelog]   - Added Enum KnownNicTypeInResponse
info	[Changelog]   - Added Enum KnownSharingScope
info	[Changelog]   - Enum KnownBastionHostSkuName has a new value Premium
info	[Changelog]   - Enum KnownEndpointType has a new value AzureArcNetwork
️❌ azure-resource-manager-schemas failed [Detail]
  • ❌Failed in generating from fa18bf0. Schema Automation 14.0.0 
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  notice
cmderr	[initScript.sh] npm notice New patch version of npm available! 10.5.0 -> 10.5.2
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.2>
cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.5.2` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
  • ❌network/resource-manager [Preview Schema Changes]
️⚠️ azure-powershell warning [Detail]
  • ⚠️Warning in generating from fa18bf0. SDK Automation 14.0.0 
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ⚠️Az.network.DefaultTag [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Apr 24, 2024 •
edited

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/network/armnetwork Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Java azure-resourcemanager-network-generated Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
JavaScript @azure/arm-network Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
.Net Azure.ResourceManager.Network Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Swagger Microsoft.Network Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

@zhaochongliu
Copy link
Author

@zhaochongliu please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”), and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your contributions to Microsoft open source projects. This Agreement is effective as of the latest signature date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

@microsoft-github-policy-service agree company="Microsoft"

This was referenced Apr 24, 2024
Draft
Draft
@zhaochongliu zhaochongliu reopened this Apr 24, 2024
This was referenced Apr 24, 2024
Draft
Draft
Draft
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 24, 2024
This was referenced Apr 24, 2024
Draft
Draft
@zhaochongliu zhaochongliu marked this pull request as draft April 24, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joanna-Yang-Art Joanna-Yang-Art Awaiting requested review from Joanna-Yang-Art Joanna-Yang-Art is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ARMReview customer-reported Issues that are reported by GitHub users external to the Azure organization. resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhaochongliu @AzureRestAPISpecReview @leoAzure20