-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark: Adds region to configuration options #4478
Open
j82w
wants to merge
6
commits into
master
Choose a base branch
from
users/j82w/regionInfo
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j82w
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
May 9, 2024 21:01
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
j82w
changed the title
Benchmark: Add region to configuration options
Benchmark: Adds region to configuration options
May 9, 2024
Microsoft.Azure.Cosmos.Samples/Tools/Benchmark/BenchmarkConfig.cs
Outdated
Show resolved
Hide resolved
kirankumarkolli
previously approved these changes
May 11, 2024
1 task
ealsur
approved these changes
May 13, 2024
RaviTella
approved these changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This PR adds an optional ApplicationPreferredRegions to the benchmark arguments. This allows users to target specific regions for different workloads, and allows benchmark to run during failovers.
Example:
dotnet run CosmosBenchmark.csproj -e https://myTest.documents-test.windows-int.net:443/ -k superlongsecretkey== -w ReadStreamExistsV3BenchmarkOperation --ApplicationPreferredRegions "North Central US,West US 2,Central US"
Type of change
Please delete options that are not relevant.