[Internal] Direct Package Upgrade: Refactors Code to Bump Up Cosmos.Direct Package to 3.34.0
#4477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kundadebdatta
requested review from
kirankumarkolli,
ealsur,
FabianMeiswinkel,
kirillg and
sboshra
as code owners
NaluTripician
approved these changes
May 9, 2024
|
Can we list the release notes that needs to go in? Fabians changes are in this direct right? |
kirankumarkolli
approved these changes
May 9, 2024
j82w
reviewed
May 9, 2024
Pilchie
approved these changes
May 9, 2024
microsoft-github-policy-service
bot
deleted the
users/kundadebdatta/upgrade_direct_package
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This PR bumps up the
Cosmos.Directpackage version to3.34.0which is released on top ofEN20240415release. In a nut-shell, the change is focused on reducing the number of barrier requests issued for Global Strong in the Microsoft Azure Documents project.The fix modifies the logic for issuing barrier requests, introducing a delay mechanism to reduce the number of requests and improve efficiency. The changes also include additional status codes for better error handling.
In
QuorumReader.cs, the retry loop logic has been modified to include a delay mechanism based on thedefaultBarrierRequestDelaysarray andremainingDelayvariable. The logic for handling responses has also been updated.In
BarrierRequestHelper.cs, new methods have been added to determine if a delay should be injected before the first barrier request and between barrier requests based on the responses to previous barrier requests.In
ConsistencyWriter.cs, theWaitForWriteBarrierAsyncmethod now includes a delay before the first barrier request and between barrier requests.In
StatusCodes.cs, new status codes have been added to handle different scenarios when the targeted LSN/GCLSN is missed.Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber