New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FaultInjection: Adds ApplyPercentage for ServerErrorRule #4450
Merged
microsoft-github-policy-service
merged 13 commits into
master
from
users/nalutripician/FaultInjectionServerErrorRuleThreshold
May 7, 2024
Merged
FaultInjection: Adds ApplyPercentage for ServerErrorRule #4450
microsoft-github-policy-service
merged 13 commits into
master
from
users/nalutripician/FaultInjectionServerErrorRuleThreshold
May 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NaluTripician
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
April 23, 2024 22:33
...soft.Azure.Cosmos.Samples/Tools/FaultInjection/src/FaultInjectionServerErrorResultBuilder.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos.Samples/Tools/FaultInjection/src/FaultInjectionServerErrorResult.cs
Outdated
Show resolved
Hide resolved
...ure.Cosmos.Samples/Tools/FaultInjection/src/implementataion/FaultInjectionServerErrorRule.cs
Show resolved
Hide resolved
kirankumarkolli
previously approved these changes
Apr 30, 2024
bartelink
reviewed
Apr 30, 2024
...ure.Cosmos.Samples/Tools/FaultInjection/src/implementataion/FaultInjectionServerErrorRule.cs
Outdated
Show resolved
Hide resolved
NaluTripician
changed the title
FaultInjection: Adds ApplicationPercentage for ServerErrorRule
FaultInjection: Adds ApplyPercentage for ServerErrorRule
Apr 30, 2024
...soft.Azure.Cosmos.Samples/Tools/FaultInjection/src/FaultInjectionServerErrorResultBuilder.cs
Outdated
Show resolved
Hide resolved
kundadebdatta
approved these changes
May 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
kirankumarkolli
approved these changes
May 7, 2024
microsoft-github-policy-service
bot
deleted the
users/nalutripician/FaultInjectionServerErrorRuleThreshold
branch
May 7, 2024 03:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Adds Application Percentage for ServerErrorRules. This allows users to specify how frequently server error rules are applied. For instance, by setting this value to
.5
that rule will be applied 50% of the time. This value is 1, or 100%, by default.Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber