Query: Fixes Persisted continuationToken issue by turning off ODE by default #4413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityasa
force-pushed
the
users/adityasa/TurnOffOde
branch
from
ab760df
to
139d6e6
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ontainer (failure case).
sboshra
reviewed
Apr 23, 2024
Microsoft.Azure.Cosmos/src/Query/Core/Pipeline/CosmosQueryExecutionContextFactory.cs
Outdated
Show resolved
Hide resolved
sboshra
reviewed
Apr 23, 2024
Microsoft.Azure.Cosmos/src/Query/Core/Pipeline/CosmosQueryExecutionContextFactory.cs
Outdated
Show resolved
Hide resolved
sboshra
reviewed
Apr 23, 2024
Microsoft.Azure.Cosmos/src/Query/Core/Pipeline/CosmosQueryExecutionContextFactory.cs
Outdated
Show resolved
Hide resolved
adityasa
requested review from
khdang,
neildsh,
kirankumarkolli,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
adityasa
force-pushed
the
users/adityasa/TurnOffOde
branch
from
4d49460
to
86ab8a2
Compare
Maya-Painter
approved these changes
Apr 23, 2024
sboshra
approved these changes
Apr 24, 2024
microsoft-github-policy-service
bot
deleted the
users/adityasa/TurnOffOde
branch
adityasa
added a commit
that referenced
this pull request
May 15, 2024
…default (#4413) * Turn of ODE by default. * Updated tests * Update * Test fix * Added test for query resumption with ODE token with partition split container (failure case). * Update. * Update Benchmark * Addressed comments.
adityasa
added a commit
that referenced
this pull request
May 15, 2024
…default (#4413) * Turn of ODE by default. * Updated tests * Update * Test fix * Added test for query resumption with ODE token with partition split container (failure case). * Update. * Update Benchmark * Addressed comments.
adityasa
added a commit
that referenced
this pull request
May 16, 2024
…default (#4413) * Turn of ODE by default. * Updated tests * Update * Test fix * Added test for query resumption with ODE token with partition split container (failure case). * Update. * Update Benchmark * Addressed comments.
microsoft-github-policy-service bot
pushed a commit
that referenced
this pull request
May 16, 2024
…ch (#4498) * Fix bug in OrderByCrossPartitionQueryPipelineStage to ensure that failures in creating the inner pipeline stage are bubbled up to the higher stages (#4419) * Query: Fixes Persisted continuationToken issue by turning off ODE by default (#4413) * Turn of ODE by default. * Updated tests * Update * Test fix * Added test for query resumption with ODE token with partition split container (failure case). * Update. * Update Benchmark * Addressed comments. --------- Co-authored-by: neildsh <35383880+neildsh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This change fixes the issue with persisted continuation tokens by turning off ODE by Default. The issue is hit by DataVerse team where continuation tokens for a given query are persisted for long periods of time. If query that originally started with ODE resumes execution after partition split has occurred, it currently fails with following error message:
Microsoft.Azure.Cosmos.CosmosException : Response status code does not indicate success: BadRequest (400); Substatus: 20007; ActivityId: ; Reason: (Response status code does not indicate success: BadRequest (400); Substatus: 20007; ActivityId: ; Reason: (Invalid format for continuation token {"OptimisticDirectExecutionToken":{"token":"{"OptimisticDirectExecutionToken". . .Currently this issue is tracked by #4432, however the fix for that issue is much more involved, since it requires hydrate a continuation token required by non-ODE pipelines from original ODE continuation token.
As a mitigation, this change turns off ODE by default, unless a continuation of an ODE query is being executed.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber