Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CosmosClient initialization ergonomics #4405

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Improve CosmosClient initialization ergonomics #4405

wants to merge 5 commits into from
+37 −19

Commits on Apr 11, 2024

  1. Make InitializeContainersAsync public

    @onionhammer
    onionhammer committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    6efa8a7 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Added missing doccomment

    @onionhammer
    onionhammer committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    adfeaf2 View commit details
    Browse the repository at this point in the history

  2. Only the async factory method should dispose on exception

    @onionhammer
    onionhammer committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    f282d6b View commit details
    Browse the repository at this point in the history

  3. Pre-allocate enough room in tasks list, allow cancellationtoken to be… 

    … default
    @onionhammer
    onionhammer committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    dde8fc3 View commit details
    Browse the repository at this point in the history

  4. Added additional doccomment to describe behavior of internal vs non-i… 

    …nternal `initialize` call
    @onionhammer
    onionhammer committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    d7f73da View commit details
    Browse the repository at this point in the history