[Internal] Benchmark metrics tests #3962
Conversation
This reverts commit c7da088.
M-Lipin
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"
Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
| <PackageReference Include="CommandLineParser" Version="2.8.0" /> | ||
| <PackageReference Include="MathNet.Numerics" Version="4.15.0" /> | ||
| <PackageReference Include="Microsoft.Azure.DocumentDB.Core" Version="*" /> | ||
| <PackageReference Include="OpenTelemetry.Exporter.Console" Version="1.5.0" /> |
| @@ -17,9 +17,11 @@ | |||
| </None> | |||
| </ItemGroup> | |||
| <ItemGroup> | |||
| <PackageReference Include="Azure.Monitor.OpenTelemetry.Exporter" Version="1.0.0-beta.12" /> | |||
There was a problem hiding this comment.
are you planning to support other APM tools also? other than AppInsights. If no, I would recommend you to use AppInsight SDK library instead of this prerelease version of exporter.
Looks like it is more than just unit tests. Can you please explain what exactly you are covering as part of this PR. |
Benchmark metrics tests
Description
Adding unit tests for Cosmos DB Benchmark metrics.
Type of change
Please delete options that are not relevant.
Closing issues
Blocks #3892