Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve issue 4296 #4599

Closed
wants to merge 4 commits into from
Closed

resolve issue 4296 #4599

wants to merge 4 commits into from

Conversation

chunyu3
Copy link
Member

@chunyu3 chunyu3 commented Apr 18, 2024

Description

Fix #4296

  • propagate encode information to each Union variant

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@chunyu3 chunyu3 added the DPG label Apr 18, 2024
chunyu3
chunyu3 commented Apr 19, 2024
View reviewed changes
Copy link
Member Author

@chunyu3 chunyu3 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Unit test and E2E test, will add cadl-ranch test soon.

This was referenced Apr 19, 2024
Closed
Closed
Draft
@chunyu3
Copy link
Member Author

chunyu3 commented Apr 22, 2024

micorsoft/typespec pr: microsoft/typespec#3200

ArcturusZhang
ArcturusZhang approved these changes Apr 28, 2024
View reviewed changes
Copy link
Member

@ArcturusZhang ArcturusZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a cadl-ranch case for this? Maybe we could add that test in this PR as well

@chunyu3 chunyu3 closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@lirenhe lirenhe Awaiting requested review from lirenhe lirenhe is a code owner

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

@hallipr hallipr Awaiting requested review from hallipr hallipr is a code owner

@JoshLove-msft JoshLove-msft Awaiting requested review from JoshLove-msft JoshLove-msft is a code owner

Assignees
No one assigned
Labels
DPG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nullable DateTimeOffset is not parsed from Unix timestamp
2 participants
@chunyu3 @ArcturusZhang