[Mgmt]Build enums from code model converter #4576
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to gradually support code model conversion to input types with several PRs, instead of a huge PR at one time.
Current behavior:
We have
public TypeProvider(Schema schem){}
Final goal:
We want:
InputType inputType = CodeModelConverter.From(schema)
.public TypeProvider(InputType inputType){}
Solution:
We could support one kind of schema/input type pair at one time. For example, in this PR, it supports
ChoiceSchema/InputEnumType
. Therefore this PR would introduce (which actually already exists):InputEnumType inputType = CodeModelConverter.From(ChoiceSchema/SealedChoiceSchema)
.public EnumType(InputEnumType inputType){}
To support one type at one time, we might need to expose
CodeModelConverter
and the mappings it builds temporarily as what this PR did. In the transition period,CodeModelConverter
is exposed all the time.After we convert all the types to input types, we remove all the exposed things from
CodeModelConverter
.