New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate AdditionalProperties
with raw data field (Phase 1)
#4510
Merged
ArcturusZhang
merged 54 commits into
Azure:feature/v3
from
ArcturusZhang:phase1-of-additionalproperties
May 10, 2024
Merged
Consolidate AdditionalProperties
with raw data field (Phase 1)
#4510
ArcturusZhang
merged 54 commits into
Azure:feature/v3
from
ArcturusZhang:phase1-of-additionalproperties
May 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArcturusZhang
force-pushed
the
phase1-of-additionalproperties
branch
from
April 1, 2024 10:25
56c334f
to
2ffbdaf
Compare
ArcturusZhang
force-pushed
the
phase1-of-additionalproperties
branch
from
April 1, 2024 10:28
2ffbdaf
to
03dc014
Compare
ArcturusZhang
commented
Apr 2, 2024
...Rest.CSharp/Common/Output/Models/Serialization/Json/JsonAdditionalPropertiesSerialization.cs
Show resolved
Hide resolved
ArcturusZhang
force-pushed
the
phase1-of-additionalproperties
branch
from
April 2, 2024 01:51
78c93af
to
4d673cb
Compare
6 tasks
This comment was marked as outdated.
This comment was marked as outdated.
ArcturusZhang
force-pushed
the
phase1-of-additionalproperties
branch
from
April 15, 2024 08:55
21ed249
to
0c5b0df
Compare
ArcturusZhang
requested review from
m-nash,
lirenhe,
ArthurMa1978,
hallipr and
JoshLove-msft
as code owners
April 29, 2024 03:49
lirenhe
approved these changes
Apr 29, 2024
ArthurMa1978
approved these changes
Apr 29, 2024
live1206
approved these changes
Apr 30, 2024
Co-authored-by: Wei Hu <live1206@gmail.com>
Co-authored-by: Wei Hu <live1206@gmail.com>
m-nash
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4128
For phases, please refer #4465
Description
...Record<T>
syntax for additional properties.Main changes in the generator:
...Record<T>
syntax for additional properties. I think we do not have to have a perfect solution for that because the perfect solution for this is adoptinggetAllModels
from TCGC, therefore that change is just making it work.AdditionalPropertiesSerialization
and aRawDataFieldSerialization
since a model might have both when its additionalProperties property cannot catch everything up.Checklist
To ensure a quick review and merge, please ensure:
Ready to Land?