-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/1password #9980
base: master
Are you sure you want to change the base?
Feature/1password #9980
Conversation
@v-prasadboke Looks like we're all squared away and just awaiting review from MS. Let me or @azurekid know if there are any other changes required. |
@v-prasadboke , @v-atulyadav, @urajat, could one of you kindly provide a response? We missed our go-live date, and it's crucial to know if there are any updates or impediments. This PR has been ongoing for 90 days now, and clarity would be greatly appreciated. |
Hello @azurekid, Sorry was on leave till yesterday from last saturday. Was waiting for your committs to complete. |
Hi @v-prasadboke , Let's see if we can wrap this up together today. @scottisloud FYI |
Hello @azurekid, Can you update this branch from master once |
Just did 👍 |
6d0aa8e
to
97c177e
Compare
Hi @v-prasadboke, Also added some extra error handling in the function code and zip file. Now it seems to fail on the KQL in the
|
latest commits from PR
8d291b8
to
31605fa
Compare
Okay cool! |
Hello @azurekid, On my test branch, I was looking for the cause for validation failure. Even I tried to replace the code in the data connector with another data connector. We can skip this validation failure but need to discuss this within team whether the validation failure is legit or not OR can it be skipped Thanks and sorry for the delay in response. |
Thanks! I am glad we came to the same conclusion regarding this. Would love to see how we can put a bit more pressure on it so organizations can start to test the preview version and provide us with valuable feedback. @scottisloud for visibility |
Noted @azurekid, Will get this complete soonest |
Thanks @azurekid and @v-prasadboke for all of your hard work to help bring this solution across the finish line. |
Change(s):
Alert Rules
Data Connector
1Password_API_FunctionApp.json
Workbooks
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present: