Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Jq filter to allow empty defaultValue for policy definition and set definition #875

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Fix Jq filter to allow empty defaultValue for policy definition and set definition #875

merged 1 commit into from
Apr 19, 2024

Conversation

Jefajers
Copy link
Member

Overview/Summary

This PR fixes #874 by adjusting policyDefinitions.jq and policySetDefinitions.jq to allow defaultValue to be empty.

This PR fixes/adds/changes/removes

  1. Changes policyDefinitions.jq
  2. Changes policySetDefinitions.jq

Breaking Changes

N/A

Testing Evidence

Tests have been performed to evaluate if empty defaultValue is pulled back and persisted while still removing other unwanted empty key value pairs.

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@Jefajers Jefajers added the bug Something isn't working label Apr 17, 2024
@Jefajers Jefajers added this to the v2.6.2 milestone Apr 17, 2024
@Jefajers Jefajers requested review from a team as code owners April 17, 2024 15:06
@Jefajers Jefajers added this to In progress in AzOps Apr 17, 2024
@Jefajers Jefajers moved this from In progress to Needs review in AzOps Apr 17, 2024
daltondhcp
daltondhcp approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@daltondhcp daltondhcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Jefajers Jefajers merged commit 76f93b4 into Azure:main Apr 19, 2024
4 checks passed
@Jefajers Jefajers deleted the updateJqTemplate branch April 19, 2024 08:05
@Jefajers Jefajers moved this from Needs review to Pending release in AzOps Apr 19, 2024
@Jefajers Jefajers moved this from Pending release to Done in AzOps Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltondhcp daltondhcp daltondhcp approved these changes

Assignees

@daltondhcp daltondhcp

Labels
bug Something isn't working
Projects
AzOps
Done
Milestone
v2.6.2
Development

Successfully merging this pull request may close these issues.

PolicySetDefinition empty defaultValue is removed
2 participants
@Jefajers @daltondhcp