Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Keychain Security Group name #66 #67

Merged
merged 1 commit into from
May 28, 2024

Conversation

ptittof57
Copy link
Contributor

Purpose

This is a fix for #66, Maui iOS application crash after login

Does this introduce a breaking change?

[ ] Yes
[ x ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

Run this code on iOS simulator

What to Check

Verify that the following are valid

  • ...
    Check that you can login without crash and application display claim view

Other Information

I have update on my side to .NET 9 preview 3, iOS 15.0 Simulator iPhone 13

Copy link

@billyjacobs2014 billyjacobs2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be msalcache in the entitlements file. Not this way because it is msal now, not adal. So the update should occur in entitlements.plist.

Copy link
Contributor

@bgavrilMS bgavrilMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, the com.microsoft.adalcache is the default one

@bgavrilMS bgavrilMS merged commit 176cd90 into Azure-Samples:main May 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants